Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365692 )
Change subject: Hygiene: Introduce phpcs checks for MinervaNeue skin
......................................................................
Hygiene: Introduce phpcs checks for MinervaNeue skin
Changes:
- introduced basic composer installation and phpcs.xml config file
Change-Id: I53642e9d7bc1ef96e359cfe04a8f93dabbc977eb
---
A composer.json
A phpcs.xml
2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/92/365692/1
diff --git a/composer.json b/composer.json
new file mode 100644
index 0000000..1366381
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,16 @@
+{
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "mediawiki/mediawiki-codesniffer": "0.10.0",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor",
+ "phpcs -p -s"
+ ],
+ "fix": [
+ "phpcbf"
+ ]
+ }
+}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..0b73696
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0"?>
+<ruleset>
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName"/>
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
+ <exclude
name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage"/>
+ <exclude name="MediaWiki.Commenting.FunctionComment"/>
+ </rule>
+ <file>.</file>
+ <arg name="extensions" value="php,php5,inc"/>
+ <arg name="encoding" value="UTF-8"/>
+ <exclude-pattern>vendor</exclude-pattern>
+ <exclude-pattern>node_modules</exclude-pattern>
+
+ <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
+ <properties>
+ <property name="equalsSpacing" value="1" />
+ <property name="requiredSpacesAfterOpen"
value="1"/>
+ <property name="requiredSpacesBeforeClose"
value="1" />
+ </properties>
+ </rule>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/365692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53642e9d7bc1ef96e359cfe04a8f93dabbc977eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
