jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363098 )
Change subject: Visual diffs: Use new wgDiffOldId/wgDiffNewId
......................................................................
Visual diffs: Use new wgDiffOldId/wgDiffNewId
This also removes an undeclared dependency on mediawiki.Uri.
Bug: T169574
Depends-On: Ic4abaae6e9c74509f7a114a697cdbb78dd1b89b6
Change-Id: I76803da5f1a52171a1af8de1f3e31ea127a2da78
---
M modules/ve-mw/init/ve.init.mw.DiffPage.init.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
b/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
index 90a307d..8ec60eb 100644
--- a/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
+++ b/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
@@ -36,8 +36,8 @@
var oldRevPromise, newRevPromise, modulePromise, progress,
$revSlider = $( '.mw-revslider-container' ),
$wikitextDiff = $( 'table.diff[data-mw="interface"]' ),
- oldId = +( new mw.Uri() ).query.oldid,
- newId = mw.config.get( 'wgRevisionId' );
+ oldId = mw.config.get( 'wgDiffOldId' ),
+ newId = mw.config.get( 'wgDiffNewId' );
mode = item.getData();
--
To view, visit https://gerrit.wikimedia.org/r/363098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76803da5f1a52171a1af8de1f3e31ea127a2da78
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
