jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366038 )
Change subject: maintenance: Add --dry-run option to deleteDefaultMessages.php
......................................................................
maintenance: Add --dry-run option to deleteDefaultMessages.php
For back-compat, keep the default as-is, because it is also
used as a post-update script by the installer.
But for convenience and safe manual use, do add a dry-run option.
(Ideally this would be a --delete option and dry-run by default.)
Change-Id: I3ca70f15f50b66f9d19fa705cef9a4aae2dd4e5c
---
M maintenance/deleteDefaultMessages.php
1 file changed, 15 insertions(+), 5 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/deleteDefaultMessages.php
b/maintenance/deleteDefaultMessages.php
index 69f4f89..ba8662a 100644
--- a/maintenance/deleteDefaultMessages.php
+++ b/maintenance/deleteDefaultMessages.php
@@ -35,6 +35,7 @@
parent::__construct();
$this->addDescription( 'Deletes all pages in the MediaWiki
namespace' .
' which were last edited by "MediaWiki default"' );
+ $this->addOption( 'dry-run', 'Perform a dry run, delete
nothing' );
}
public function execute() {
@@ -52,14 +53,23 @@
);
if ( $dbr->numRows( $res ) == 0 ) {
- # No more messages left
+ // No more messages left
$this->output( "done.\n" );
-
return;
}
- # Deletions will be made by $user temporarly added to the bot
group
- # in order to hide it in RecentChanges.
+ $dryrun = $this->hasOption( 'dry-run' );
+ if ( $dryrun ) {
+ foreach ( $res as $row ) {
+ $title = Title::makeTitle(
$row->page_namespace, $row->page_title );
+ $this->output( "\n* [[$title]]" );
+ }
+ $this->output( "\n\nRun again without --dry-run to
delete these pages.\n" );
+ return;
+ }
+
+ // Deletions will be made by $user temporarly added to the bot
group
+ // in order to hide it in RecentChanges.
$user = User::newFromName( 'MediaWiki default' );
if ( !$user ) {
$this->error( "Invalid username", true );
@@ -67,7 +77,7 @@
$user->addGroup( 'bot' );
$wgUser = $user;
- # Handle deletion
+ // Handle deletion
$this->output( "\n...deleting old default messages (this may
take a long time!)...", 'msg' );
$dbw = $this->getDB( DB_MASTER );
--
To view, visit https://gerrit.wikimedia.org/r/366038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ca70f15f50b66f9d19fa705cef9a4aae2dd4e5c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Gilles <gdu...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
