Jonas Kress (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366165 )
Change subject: [WIP] Complete fullscreen
......................................................................
[WIP] Complete fullscreen
Change-Id: I06d8f723df09611be73d13caeace2fcdf45271fe
---
M index.html
M style.css
M wikibase/queryService/ui/App.js
3 files changed, 21 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/65/366165/1
diff --git a/index.html b/index.html
index 4fab6e6..9f69e6a 100644
--- a/index.html
+++ b/index.html
@@ -36,7 +36,7 @@
<script src="node_modules/es6-shim/es6-shim.js"></script>
<!-- endbuild -->
</head>
-<body>
+<body id="app">
<div class="wikibase-queryservice container-fluid">
<div class="row">
<!-- Editor Navbar -->
diff --git a/style.css b/style.css
index 5f8f4ce..d1ffa1c 100644
--- a/style.css
+++ b/style.css
@@ -1,5 +1,10 @@
body {
overflow-y: scroll;
+ width: 100%;
+ height: 100%
+}
+.wikibase-queryservice {
+ background-color: white;
}
.error {
margin: 20px;
diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index 5592514..4888af2 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -375,12 +375,25 @@
$( '.fullscreen' ).click( function( e ) {
e.preventDefault();
- self._editor.toggleFullscreen();
- self._editor.focus();
var $help = $( '<a target="_blank" rel="noopener"
href="https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Wikidata_Query_Help/SPARQL_Editor#Editor_Toolbar";>'
)
.append( $.i18n(
'wdqs-app-toast-leave-fullscreen' ) );
self._toast( $help, 'wdqs-app-toast-leave-fullscreen' );
+
+ var i = document.getElementById("app");
+
+ if (i.requestFullscreen) {
+ i.requestFullscreen();
+ } else if (i.webkitRequestFullscreen) {
+ i.webkitRequestFullscreen();
+ } else if (i.mozRequestFullScreen) {
+ i.mozRequestFullScreen();
+ } else if (i.msRequestFullscreen) {
+ i.msRequestFullscreen();
+ }
+
+ //self._editor.toggleFullscreen();
+ //self._editor.focus();
} );
$( window ).on( 'popstate', $.proxy( this._initQuery, this ) );
--
To view, visit https://gerrit.wikimedia.org/r/366165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06d8f723df09611be73d13caeace2fcdf45271fe
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
