jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366258 )
Change subject: Use mt_getrandmax() in NewSense
......................................................................
Use mt_getrandmax() in NewSense
Same as in other similar functions. The problem with this constant was
that it was bigger than INT32.
Change-Id: I7436b4df0728e4f180dbcd258faf08a680f5c63d
---
M tests/phpunit/composer/DataModel/NewForm.php
M tests/phpunit/composer/DataModel/NewSense.php
2 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/composer/DataModel/NewForm.php
b/tests/phpunit/composer/DataModel/NewForm.php
index d3be64e..46cc60a 100644
--- a/tests/phpunit/composer/DataModel/NewForm.php
+++ b/tests/phpunit/composer/DataModel/NewForm.php
@@ -158,6 +158,9 @@
$this->statements = $this->cloneArrayOfObjects(
$this->statements );
}
+ /**
+ * @return FormId
+ */
private function newRandomFormId() {
return new FormId( 'F' . mt_rand( 1, mt_getrandmax() ) );
}
diff --git a/tests/phpunit/composer/DataModel/NewSense.php
b/tests/phpunit/composer/DataModel/NewSense.php
index 1dd6890..3ada87c 100644
--- a/tests/phpunit/composer/DataModel/NewSense.php
+++ b/tests/phpunit/composer/DataModel/NewSense.php
@@ -103,6 +103,9 @@
return $result;
}
+ /**
+ * @return Sense
+ */
public function build() {
return new Sense(
$this->senseId,
@@ -111,8 +114,11 @@
);
}
+ /**
+ * @return SenseId
+ */
private function generateSenseId() {
- return new SenseId( 'S' . mt_rand( 1, 4e9 ) );
+ return new SenseId( 'S' . mt_rand( 1, mt_getrandmax() ) );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/366258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7436b4df0728e4f180dbcd258faf08a680f5c63d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
