jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366304 )
Change subject: Empty Activity for showing a compilation's details
......................................................................
Empty Activity for showing a compilation's details
Bug: T164385
Change-Id: Ic9848bbcd162b9c3a09a8d7552aa07974117eefb
---
M app/src/main/AndroidManifest.xml
A app/src/main/java/org/wikipedia/offline/CompilationDetailActivity.java
A app/src/main/java/org/wikipedia/offline/CompilationDetailFragment.java
M app/src/main/java/org/wikipedia/offline/LocalCompilationsFragment.java
4 files changed, 36 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 20e98c9..46b17d8 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -190,6 +190,10 @@
android:theme="@style/AppTheme"
android:windowSoftInputMode="adjustResize"/>
+ <activity
+ android:name=".offline.CompilationDetailActivity"
+ android:theme="@style/AppTheme"/>
+
<provider
android:authorities="${applicationId}"
android:name=".database.AppContentProvider"
diff --git
a/app/src/main/java/org/wikipedia/offline/CompilationDetailActivity.java
b/app/src/main/java/org/wikipedia/offline/CompilationDetailActivity.java
new file mode 100644
index 0000000..0c05495
--- /dev/null
+++ b/app/src/main/java/org/wikipedia/offline/CompilationDetailActivity.java
@@ -0,0 +1,19 @@
+package org.wikipedia.offline;
+
+import android.content.Context;
+import android.content.Intent;
+import android.support.annotation.NonNull;
+
+import org.wikipedia.activity.SingleFragmentActivity;
+
+public class CompilationDetailActivity extends
SingleFragmentActivity<CompilationDetailFragment> {
+
+ public static Intent newIntent(@NonNull Context context) {
+ return new Intent(context, CompilationDetailActivity.class);
+ }
+
+ @Override
+ protected CompilationDetailFragment createFragment() {
+ return CompilationDetailFragment.newInstance();
+ }
+}
diff --git
a/app/src/main/java/org/wikipedia/offline/CompilationDetailFragment.java
b/app/src/main/java/org/wikipedia/offline/CompilationDetailFragment.java
new file mode 100644
index 0000000..2443843
--- /dev/null
+++ b/app/src/main/java/org/wikipedia/offline/CompilationDetailFragment.java
@@ -0,0 +1,12 @@
+package org.wikipedia.offline;
+
+import android.support.annotation.NonNull;
+import android.support.v4.app.Fragment;
+
+public class CompilationDetailFragment extends Fragment {
+
+ @NonNull
+ public static CompilationDetailFragment newInstance() {
+ return new CompilationDetailFragment();
+ }
+}
diff --git
a/app/src/main/java/org/wikipedia/offline/LocalCompilationsFragment.java
b/app/src/main/java/org/wikipedia/offline/LocalCompilationsFragment.java
index 2b60f64..a6e18a1 100644
--- a/app/src/main/java/org/wikipedia/offline/LocalCompilationsFragment.java
+++ b/app/src/main/java/org/wikipedia/offline/LocalCompilationsFragment.java
@@ -222,6 +222,7 @@
private class ItemCallback implements PageItemView.Callback<Compilation> {
@Override
public void onClick(@Nullable Compilation item) {
+ startActivity(CompilationDetailActivity.newIntent(getContext()));
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/366304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9848bbcd162b9c3a09a8d7552aa07974117eefb
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
