jenkins-bot has submitted this change and it was merged.
Change subject: (bug 45703) Leave the previous message visible after sliding up
......................................................................
(bug 45703) Leave the previous message visible after sliding up
Change-Id: I01092c84aafc9d72fca022f38ca1eb9e4628efc6
---
M resources/js/ext.translate.editor.js
M resources/js/ext.translate.messagetable.js
2 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index ad179df..d6432b9 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -172,10 +172,9 @@
* Jump to the next translation editor row.
*/
next: function () {
- var $next;
+ var $next = this.$editTrigger.next( '.tux-message' );
- $next = this.$editTrigger.next( '.tux-message' );
-
+ // If this is the last message, just hide it
if ( !$next.length ) {
this.hide();
@@ -184,12 +183,12 @@
$next.data( 'translateeditor' ).show();
- // scroll the page a little bit up, slowly.
+ // Scroll the page a little bit up, slowly.
if ( $( document ).height() -
( $( window ).height() + window.pageYOffset +
$next.height() ) > 0
) {
$( 'html, body' ).stop().animate( {
- scrollTop: $(
'.tux-message-editor:visible' ).offset().top - 55
+ scrollTop: $(
'.tux-message-editor:visible' ).offset().top - 85
}, 500 );
}
},
diff --git a/resources/js/ext.translate.messagetable.js
b/resources/js/ext.translate.messagetable.js
index 813aff7..4b22530 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -577,8 +577,8 @@
// Header:
$tuxTableHeader = $( '.tux-messagetable-header' );
isTableHeaderFloating = $tuxTableHeader.hasClass(
'floating' );
- needsTableHeaderFloat = messageListTop -
$tuxTableHeader.height() - $window.scrollTop() < 0;
- needsTableHeaderStick = messageListTop +
$tuxTableHeader.height() - $window.scrollTop() >= 0;
+ needsTableHeaderFloat = messageListTop -
$tuxTableHeader.height() - $window.scrollTop() + 10 < 0;
+ needsTableHeaderStick = messageListTop -
$tuxTableHeader.height() - $window.scrollTop() - 10 >= 0;
if ( needsTableHeaderFloat ) {
$tuxTableHeader.addClass( 'floating' ).width(
this.$container.width() );
} else if ( needsTableHeaderStick ) {
--
To view, visit https://gerrit.wikimedia.org/r/53352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01092c84aafc9d72fca022f38ca1eb9e4628efc6
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
