Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366562 )
Change subject: VE: Disable mw-editfont when using CodeMirror
......................................................................
VE: Disable mw-editfont when using CodeMirror
Due to using bold as a highlight style, the VE overlay technique
will only work with monospaced fonts.
Change-Id: I33e3e07cf0f3d8e25dd35623286eedf28ba20ae1
---
M resources/modules/ve-cm/ve.ui.CodeMirrorAction.js
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror
refs/changes/62/366562/1
diff --git a/resources/modules/ve-cm/ve.ui.CodeMirrorAction.js
b/resources/modules/ve-cm/ve.ui.CodeMirrorAction.js
index a0ed03e..cf42607 100644
--- a/resources/modules/ve-cm/ve.ui.CodeMirrorAction.js
+++ b/resources/modules/ve-cm/ve.ui.CodeMirrorAction.js
@@ -59,6 +59,10 @@
}
} );
+ // The VE/CM overlay technique only works with monospace fonts
(as we use width-changing bold as a highlight)
+ // so revert any editfont user preference
+ surfaceView.$element.removeClass( 'mw-editfont-default
mw-editfont-sans-serif mw-editfont-serif' ).addClass( 'mw-editfont-monospace' );
+
surfaceView.$documentNode.addClass(
'WebkitTextFillColor' in document.body.style ?
've-ce-documentNode-codeEditor-webkit-hide' :
@@ -73,6 +77,9 @@
} else if ( surface.mirror && enable !== true ) {
doc.off( 'precommit', surface.mirror.veTransactionListener );
+ // Restore edit-font
+ surfaceView.$element.removeClass( 'mw-editfont-monospace'
).addClass( 'mw-editfont-' + mw.user.options.get( 'editfont' ) );
+
surfaceView.$documentNode.removeClass(
've-ce-documentNode-codeEditor-webkit-hide
ve-ce-documentNode-codeEditor-webkit'
);
--
To view, visit https://gerrit.wikimedia.org/r/366562
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33e3e07cf0f3d8e25dd35623286eedf28ba20ae1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
