jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/365906 )
Change subject: Remove globe/quantity/time from the experts/getStore.js defaults
......................................................................
Remove globe/quantity/time from the experts/getStore.js defaults
The registration is now done via repo/WikibaseRepo.datatypes.php.
I'm not removing the string expert for now because it is a default in
so many cases (in tests and production), I believe it makes sense to
keep it here, even if it is redundant at the moment.
Change-Id: I388a26c7b68cda75ce78f9f92a4494bfb20ef947
---
M repo/resources/experts/getStore.js
M repo/resources/experts/resources.php
2 files changed, 6 insertions(+), 19 deletions(-)
Approvals:
Aleksey Bekh-Ivanov (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/resources/experts/getStore.js
b/repo/resources/experts/getStore.js
index c7e4f52..37f8ad2 100644
--- a/repo/resources/experts/getStore.js
+++ b/repo/resources/experts/getStore.js
@@ -14,28 +14,14 @@
/**
* @param {dataTypes.DataTypeStore} dataTypeStore
+ * @returns {jQuery.valueview.ExpertStore}
*/
MODULE.getStore = function ( dataTypeStore ) {
var expertStore = new vv.ExpertStore(
vv.experts.UnsupportedValue );
expertStore.registerDataValueExpert(
- vv.experts.GlobeCoordinateInput,
- dv.GlobeCoordinateValue.TYPE
- );
-
- expertStore.registerDataValueExpert(
- vv.experts.QuantityInput,
- dv.QuantityValue.TYPE
- );
-
- expertStore.registerDataValueExpert(
vv.experts.StringValue,
dv.StringValue.TYPE
- );
-
- expertStore.registerDataValueExpert(
- vv.experts.TimeInput,
- dv.TimeValue.TYPE
);
expertStore.registerDataValueExpert(
@@ -59,11 +45,15 @@
}
return expertStore;
-
};
+ /**
+ * @param {object} registeredExperts Map from property type to expert
module name
+ * @returns {object} Map from property type to expert constructor
+ */
function resolveExpertModules( registeredExperts ) {
var constructors = {};
+
for ( var dataType in registeredExperts ) {
if ( registeredExperts.hasOwnProperty( dataType ) ) {
constructors[ dataType ] = require(
registeredExperts[ dataType ] );
diff --git a/repo/resources/experts/resources.php
b/repo/resources/experts/resources.php
index 901a867..6548fc2 100644
--- a/repo/resources/experts/resources.php
+++ b/repo/resources/experts/resources.php
@@ -33,10 +33,7 @@
'wikibase.experts.modules',
'dataValues.values',
'jquery.valueview.ExpertStore',
- 'jquery.valueview.experts.GlobeCoordinateInput',
- 'jquery.valueview.experts.QuantityInput',
'jquery.valueview.experts.StringValue',
- 'jquery.valueview.experts.TimeInput',
'jquery.valueview.experts.UnDeserializableValue',
'jquery.valueview.experts.UnsupportedValue',
],
--
To view, visit https://gerrit.wikimedia.org/r/365906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I388a26c7b68cda75ce78f9f92a4494bfb20ef947
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <aleksey.bekh-iva...@wikimedia.de>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
