Hello Krinkle, Legoktm, jenkins-bot, VolkerE,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/366594
to review the following change.
Change subject: Revert "Remove `position: absolute` and z-index from #p-logo"
......................................................................
Revert "Remove `position: absolute` and z-index from #p-logo"
Caused the logo (which is a link to the main page) to become unclickable.
This reverts commit 909aed33cb920598558a6f36474717d95d998b84.
Bug: T171195
Change-Id: I3e215ef493568222bd4c2e0dbffc0da74241673a
---
M main.css
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MonoBook
refs/changes/94/366594/1
diff --git a/main.css b/main.css
index 82919ab..4565927 100644
--- a/main.css
+++ b/main.css
@@ -28,6 +28,10 @@
line-height: 1.5em;
}
+div#column-one {
+ padding-top: 160px;
+}
+
/* Hide, but keep accessible for screen-readers */
#column-one h2 {
position: absolute;
@@ -208,8 +212,11 @@
*/
#p-logo {
+ top: 0;
+ left: 0;
+ position: absolute; /*needed to use z-index */
+ z-index: 3;
height: 155px;
- margin-bottom: 5px;
width: 12em;
overflow: visible;
}
--
To view, visit https://gerrit.wikimedia.org/r/366594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e215ef493568222bd4c2e0dbffc0da74241673a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MonoBook
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
