Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366743 )
Change subject: Update: dark mode page background and divider colors
......................................................................
Update: dark mode page background and divider colors
Bug: T165415
Change-Id: I986f8f6794ed43e34ed1de3cf06de4b7a6406b7e
---
M app/src/main/res/layout/view_page_header.xml
M app/src/main/res/values/attrs.xml
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles_dark.xml
M app/src/main/res/values/styles_light.xml
5 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/43/366743/1
diff --git a/app/src/main/res/layout/view_page_header.xml
b/app/src/main/res/layout/view_page_header.xml
index f36ea00..b4ae11e 100644
--- a/app/src/main/res/layout/view_page_header.xml
+++ b/app/src/main/res/layout/view_page_header.xml
@@ -60,7 +60,7 @@
android:layout_marginTop="20dp"
android:layout_marginLeft="@dimen/activity_horizontal_margin"
android:layout_marginRight="@dimen/activity_horizontal_margin"
- android:background="@color/foundation_gray"/>
+ android:background="?attr/page_divider_color"/>
</LinearLayout>
<ImageView
diff --git a/app/src/main/res/values/attrs.xml
b/app/src/main/res/values/attrs.xml
index 8ebd7f5..a99577f 100644
--- a/app/src/main/res/values/attrs.xml
+++ b/app/src/main/res/values/attrs.xml
@@ -3,6 +3,7 @@
<attr name="window_background_color" format="reference"/>
<attr name="window_inverse_color" format="reference"/>
<attr name="page_background_color" format="reference"/>
+ <attr name="page_divider_color" format="reference"/>
<attr name="main_toolbar_color" format="reference"/>
<attr name="main_status_bar_color" format="reference"/>
<attr name="inline_onboarding_background_color" format="reference"/>
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index 10a16b1..a9ceec1 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -74,6 +74,7 @@
<color name="window_background_light">#fff</color>
<color name="page_background_light">#fff</color>
+ <color name="page_divider_light">@color/base50</color>
<color name="toc_background_light">#fff</color>
<color name="toc_section_text_light">#333</color>
<color name="toc_subsection_text_light">#898989</color>
@@ -89,7 +90,8 @@
<color name="multi_select_background_light">@color/accent90</color>
<color name="window_background_dark">#000</color>
- <color name="page_background_dark">#000</color>
+ <color name="page_background_dark">@color/base14</color>
+ <color name="page_divider_dark">@color/base70</color>
<color name="toc_background_dark">#0c0c0c</color>
<color name="toc_section_text_dark">#d0d0d0</color>
<color name="toc_subsection_text_dark">#a0a0a0</color>
diff --git a/app/src/main/res/values/styles_dark.xml
b/app/src/main/res/values/styles_dark.xml
index fe88552..fe192f4 100644
--- a/app/src/main/res/values/styles_dark.xml
+++ b/app/src/main/res/values/styles_dark.xml
@@ -31,6 +31,7 @@
<item name="window_background_color">@color/base10</item>
<item name="window_inverse_color">@color/base90</item>
<item name="page_background_color">@color/page_background_dark</item>
+ <item name="page_divider_color">@color/page_divider_dark</item>
<item name="main_toolbar_color">@color/accent30</item>
<item name="main_status_bar_color">@color/accent20</item>
<item name="inline_onboarding_background_color">@color/base14</item>
diff --git a/app/src/main/res/values/styles_light.xml
b/app/src/main/res/values/styles_light.xml
index f3b54ac..a4d64b8 100644
--- a/app/src/main/res/values/styles_light.xml
+++ b/app/src/main/res/values/styles_light.xml
@@ -31,6 +31,7 @@
<item name="window_background_color">@color/base90</item>
<item name="window_inverse_color">@color/base10</item>
<item name="page_background_color">@color/page_background_light</item>
+ <item name="page_divider_color">@color/page_divider_light</item>
<item name="main_toolbar_color">@color/accent50</item>
<item name="main_status_bar_color">@color/accent30</item>
<item name="inline_onboarding_background_color">@color/base80</item>
--
To view, visit https://gerrit.wikimedia.org/r/366743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I986f8f6794ed43e34ed1de3cf06de4b7a6406b7e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
