Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366744 )
Change subject: Hygiene: integrate page-library red links transform
......................................................................
Hygiene: integrate page-library red links transform
Bug: T165419
Change-Id: Ia1165e6b3800289bac5948d476f1db498b339d3d
---
M app/src/main/assets/bundle.js
M www/js/sections.js
D www/js/transforms/service/hideRedLinks.js
3 files changed, 10 insertions(+), 35 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/44/366744/1
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 25d7139..e06e855 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -91,7 +91,7 @@
module.exports = new ActionsHandler();
-},{"./bridge":2,"./utilities":20}],2:[function(require,module,exports){
+},{"./bridge":2,"./utilities":19}],2:[function(require,module,exports){
function Bridge() {
}
@@ -141,7 +141,7 @@
theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK :
pagelib.ThemeTransform.THEME.DEFAULT;
pagelib.ThemeTransform.setTheme( document, theme );
} );
-},{"./bridge":2,"wikimedia-page-library":21}],4:[function(require,module,exports){
+},{"./bridge":2,"wikimedia-page-library":20}],4:[function(require,module,exports){
var transformer = require('./transformer');
transformer.register( 'displayDisambigLink', function( content ) {
@@ -443,7 +443,7 @@
if (isLeadSection) {
transformer.transform( "moveFirstGoodParagraphUp" );
}
- transformer.transform( "hideRedLinks", content );
+ pagelib.RedLinks.hideRedLinks( document, content );
transformer.transform( "anchorPopUpMediaTransforms", content );
transformer.transform( "hideIPA", content );
} else {
@@ -676,7 +676,7 @@
bridge.sendMessage( "currentSectionResponse", { sectionID:
getCurrentSection() } );
} );
-},{"./bridge":2,"./onclick":8,"./transformer":12,"wikimedia-page-library":21}],12:[function(require,module,exports){
+},{"./bridge":2,"./onclick":8,"./transformer":12,"wikimedia-page-library":20}],12:[function(require,module,exports){
function Transformer() {
}
@@ -730,7 +730,7 @@
handleTableCollapseOrExpandClick: toggleCollapseClickCallback
};
-},{"../transformer":12,"wikimedia-page-library":21}],14:[function(require,module,exports){
+},{"../transformer":12,"wikimedia-page-library":20}],14:[function(require,module,exports){
var transformer = require("../transformer");
var collapseTables = require("./collapseTables");
@@ -861,19 +861,6 @@
},{"../../bridge":2,"../../transformer":12}],17:[function(require,module,exports){
var transformer = require("../../transformer");
-transformer.register( "hideRedLinks", function( content ) {
- var redLinks = content.querySelectorAll( 'a.new' );
- for ( var i = 0; i < redLinks.length; i++ ) {
- var redLink = redLinks[i];
- var replacementSpan = document.createElement( 'span' );
- replacementSpan.innerHTML = redLink.innerHTML;
- replacementSpan.setAttribute( 'class', redLink.getAttribute( 'class' )
);
- redLink.parentNode.replaceChild( replacementSpan, redLink );
- }
-} );
-},{"../../transformer":12}],18:[function(require,module,exports){
-var transformer = require("../../transformer");
-
// Move the first non-empty paragraph (and related elements) to the top of the
section.
// This will have the effect of shifting the infobox and/or any images at the
top of the page
// below the first paragraph, allowing the user to start reading the page
right away.
@@ -955,7 +942,7 @@
}
}
-},{"../../transformer":12}],19:[function(require,module,exports){
+},{"../../transformer":12}],18:[function(require,module,exports){
var maybeWidenImage =
require('wikimedia-page-library').WidenImage.maybeWidenImage;
var transformer = require("../transformer");
@@ -977,7 +964,7 @@
}
} );
-},{"../transformer":12,"wikimedia-page-library":21}],20:[function(require,module,exports){
+},{"../transformer":12,"wikimedia-page-library":20}],19:[function(require,module,exports){
function ancestorContainsClass( element, className ) {
var contains = false;
var curNode = element;
@@ -1026,7 +1013,7 @@
firstDivAncestor: firstDivAncestor
};
-},{}],21:[function(require,module,exports){
+},{}],20:[function(require,module,exports){
(function (global, factory) {
typeof exports === 'object' && typeof module !== 'undefined' ?
module.exports = factory() :
typeof define === 'function' && define.amd ? define(factory) :
@@ -2401,4 +2388,4 @@
})));
-},{}]},{},[2,7,20,12,13,14,19,15,16,17,18,1,4,5,6,3,9,10,11]);
+},{}]},{},[2,7,19,12,13,14,18,15,16,17,1,4,5,6,3,9,10,11]);
diff --git a/www/js/sections.js b/www/js/sections.js
index 74c7943..7ab811e 100644
--- a/www/js/sections.js
+++ b/www/js/sections.js
@@ -180,7 +180,7 @@
if (isLeadSection) {
transformer.transform( "moveFirstGoodParagraphUp" );
}
- transformer.transform( "hideRedLinks", content );
+ pagelib.RedLinks.hideRedLinks( document, content );
transformer.transform( "anchorPopUpMediaTransforms", content );
transformer.transform( "hideIPA", content );
} else {
diff --git a/www/js/transforms/service/hideRedLinks.js
b/www/js/transforms/service/hideRedLinks.js
deleted file mode 100644
index 861d1f7..0000000
--- a/www/js/transforms/service/hideRedLinks.js
+++ /dev/null
@@ -1,12 +0,0 @@
-var transformer = require("../../transformer");
-
-transformer.register( "hideRedLinks", function( content ) {
- var redLinks = content.querySelectorAll( 'a.new' );
- for ( var i = 0; i < redLinks.length; i++ ) {
- var redLink = redLinks[i];
- var replacementSpan = document.createElement( 'span' );
- replacementSpan.innerHTML = redLink.innerHTML;
- replacementSpan.setAttribute( 'class', redLink.getAttribute( 'class' )
);
- redLink.parentNode.replaceChild( replacementSpan, redLink );
- }
-} );
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/366744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1165e6b3800289bac5948d476f1db498b339d3d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
