Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366792 )
Change subject: Minimize local PHPCS rule set as much as possible ...................................................................... Minimize local PHPCS rule set as much as possible I made use of the "phpcs -e" feature to make sure that: * No sniff gets lost when switching from the previous, MediaWiki based rule set to the Wikibase based. * And at the same time there are no lines in this local phpcs.xml file that are already active via the base rule set. The PSR1 sniffs, for example, are already active. Bug: T167436 Change-Id: Id9918441d10643a2e1b3e0780bacbc2c4ecf756b --- M phpcs.xml 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cognate refs/changes/92/366792/1 diff --git a/phpcs.xml b/phpcs.xml index b7fa35b..b6910b9 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -3,12 +3,10 @@ <rule ref="./vendor/wikibase/wikibase-codesniffer/Wikibase" /> <rule ref="Generic.Formatting.NoSpaceAfterCast" /> - <rule ref="PSR1" /> - <rule ref="Squiz.Classes.ValidClassName.NotCamelCaps" /> + <rule ref="Generic.Metrics.CyclomaticComplexity" /> + <rule ref="Generic.Metrics.NestingLevel" /> <rule ref="Squiz.Operators.ValidLogicalOperators" /> - <rule ref="PSR1.Files.SideEffects.FoundWithSymbols"> - <severity>0</severity> - </rule> + <file>.</file> <exclude-pattern>node_modules</exclude-pattern> </ruleset> -- To view, visit https://gerrit.wikimedia.org/r/366792 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9918441d10643a2e1b3e0780bacbc2c4ecf756b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Cognate Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits