Tobias Gritschacher has submitted this change and it was merged.
Change subject: (bug 44543) Triggering snakviewchange when manipulating property
......................................................................
(bug 44543) Triggering snakviewchange when manipulating property
"snakviewchange" event is triggered when manipulating the snakview widget's
property input element now. External components (e.g. the toolbar) can now
react properly on when changing the property which might invalidate the snak.
Change-Id: I175c7a5d67a3fff125ed82237a049d2fc2711217
---
M lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tobias Gritschacher: Verified; Looks good to me, approved
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
index 4a33a22..dc1183f 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snaklistview.js
@@ -426,7 +426,7 @@
$.each( this._listview.items(), function( i, item ) {
var snakview = self._lia.liInstance( $( item ) );
- if ( !snakview.isValid() ) {
+ if ( !snakview.isValid() || !snakview.snak() ) {
isValid = false;
return false;
}
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index cfd542a..d270b5a 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -196,6 +196,7 @@
// remove out-dated variations
if( self._variation ) {
self.propertyId( null );
+ self._trigger( 'change' );
}
} )
.on( 'entityselectorselect', function( e, ui ) {
@@ -228,6 +229,8 @@
self.propertyId( entityId );
+ self._trigger( 'change' );
+
// Since it takes a while for the value view to
gather its data from the API,
// the property might not be valid anymore
aborting the rendering of the value
// view.
--
To view, visit https://gerrit.wikimedia.org/r/53375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I175c7a5d67a3fff125ed82237a049d2fc2711217
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
