jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366807 )
Change subject: Add explicite dependency on PHP 5.5 to composer.json
......................................................................
Add explicite dependency on PHP 5.5 to composer.json
This adds sereral keys to the composer.json declaration I find relevant.
The "composer/installers" dependency is discussed in I615c88d. I'm not
absolutely sure if it's a good idea to add it everywhere. The idea is
that it should be added to all repositories with
"type": "mediawiki-extension".
The PSR1 sniff got lost in the previous patch I2322b25 that switched
this code repository to the Wikibase code sniffer rule set.
Change-Id: Id59059c89fea9c83ac7c76e05b120a57e1368883
---
M composer.json
M phpcs.xml
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 146bf62..190a245 100644
--- a/composer.json
+++ b/composer.json
@@ -1,4 +1,11 @@
{
+ "name": "mediawiki/interwikisorting",
+ "type": "mediawiki-extension",
+ "license": "GPL-2.0+",
+ "require": {
+ "php": ">=5.5.9",
+ "composer/installers": ">=1.0.1"
+ },
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
diff --git a/phpcs.xml b/phpcs.xml
index e6b08c2..00a6fc2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -5,6 +5,7 @@
<rule ref="Generic.Formatting.NoSpaceAfterCast" />
<rule ref="Generic.Metrics.CyclomaticComplexity" />
<rule ref="Generic.Metrics.NestingLevel" />
+ <rule ref="PSR1.Files.SideEffects" />
<rule ref="Squiz.Operators.ValidLogicalOperators" />
<file>.</file>
--
To view, visit https://gerrit.wikimedia.org/r/366807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id59059c89fea9c83ac7c76e05b120a57e1368883
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/InterwikiSorting
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
