Henning Snater has submitted this change and it was merged.
Change subject: Use isOk instead of isGood
......................................................................
Use isOk instead of isGood
Goes to show that proper clear naming of APIs is important
Change-Id: I57a222f08bad2b8629ae294fdc1c2c1f57b69949
---
M repo/includes/ClaimSaver.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Henning Snater: Verified; Looks good to me, approved
diff --git a/repo/includes/ClaimSaver.php b/repo/includes/ClaimSaver.php
index 38a7e7d..d0752a4 100644
--- a/repo/includes/ClaimSaver.php
+++ b/repo/includes/ClaimSaver.php
@@ -164,7 +164,7 @@
$token
);
- if ( !$status->isGood() ) {
+ if ( !$status->isOK() ) {
throw new ExceptionWithCode( $status->getMessage(),
'setclaim-save-failed' );
}
--
To view, visit https://gerrit.wikimedia.org/r/53566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57a222f08bad2b8629ae294fdc1c2c1f57b69949
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
