Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366895 )
Change subject: Default constraint parameters to []
......................................................................
Default constraint parameters to []
I don’t know why $constraintParameters would ever be null here, but it
seems to happen, so for now default to empty parameters in that case.
Bug: T171295
Change-Id: I7ea8b8936d9b4e0beae8a5ee0cfd92b8b49a0035
---
M includes/ConstraintRepository.php
1 file changed, 12 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/95/366895/1
diff --git a/includes/ConstraintRepository.php
b/includes/ConstraintRepository.php
index 29fbd93..497e5c1 100644
--- a/includes/ConstraintRepository.php
+++ b/includes/ConstraintRepository.php
@@ -3,6 +3,7 @@
namespace WikibaseQuality\ConstraintReport;
use InvalidArgumentException;
+use MediaWiki\Logger\LoggerFactory;
use Wikimedia\Rdbms\DBUnexpectedError;
use Wikimedia\Rdbms\LikeMatch;
use Wikibase\DataModel\Entity\PropertyId;
@@ -137,6 +138,17 @@
$constraintTypeItemId = $result->constraint_type_qid;
$constraintParameters = json_decode(
$result->constraint_parameters, true );
+ if ( $constraintParameters === null ) {
+ // T171295
+ LoggerFactory::getInstance(
'WikibaseQualityConstraints' )
+ ->warning( 'Constraint {constraintId}
has invalid constraint parameters.', [
+ 'method' => __METHOD__,
+ 'constraintId' =>
$result->constraint_guid,
+ 'constraintParameters' =>
$result->constraint_parameters,
+ ] );
+ $constraintParameters = [];
+ }
+
$constraints[] = new Constraint(
$result->constraint_guid,
PropertyId::newFromNumber( $result->pid ),
--
To view, visit https://gerrit.wikimedia.org/r/366895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ea8b8936d9b4e0beae8a5ee0cfd92b8b49a0035
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
