jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366862 )
Change subject: Add Explore overflow option to access compilations.
......................................................................
Add Explore overflow option to access compilations.
This adds an option to the overflow menu in the feed for accessing the
local compilations list. This makes compilations accessible regardless of
whether the user is offline or online.
Change-Id: I7f4632c942244f2028a232524bcdb00173def819
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
M app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
M app/src/main/res/layout/view_explore_overflow.xml
3 files changed, 16 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index af8ba6a..5d1276a 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -480,5 +480,10 @@
WikipediaApp.getInstance().logOut();
FeedbackUtil.showMessage(FeedFragment.this,
R.string.toast_logout_complete);
}
+
+ @Override
+ public void compilationsClick() {
+ startActivity(LocalCompilationsActivity.newIntent(getContext()));
+ }
}
}
diff --git a/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
b/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
index cf19813..1c56497 100644
--- a/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
+++ b/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
@@ -26,6 +26,7 @@
public interface Callback {
void loginClick();
void logoutClick();
+ void compilationsClick();
void settingsClick();
void donateClick();
}
@@ -53,7 +54,8 @@
}
@OnClick({R.id.explore_overflow_settings, R.id.explore_overflow_donate,
- R.id.explore_overflow_account_container,
R.id.explore_overflow_log_out})
+ R.id.explore_overflow_account_container,
R.id.explore_overflow_log_out,
+ R.id.explore_overflow_compilations})
void onItemClick(View view) {
if (popupWindowHost != null) {
popupWindowHost.dismiss();
@@ -68,6 +70,9 @@
callback.loginClick();
}
break;
+ case R.id.explore_overflow_compilations:
+ callback.compilationsClick();
+ break;
case R.id.explore_overflow_settings:
callback.settingsClick();
break;
diff --git a/app/src/main/res/layout/view_explore_overflow.xml
b/app/src/main/res/layout/view_explore_overflow.xml
index ff534d6..4c4037f 100644
--- a/app/src/main/res/layout/view_explore_overflow.xml
+++ b/app/src/main/res/layout/view_explore_overflow.xml
@@ -46,6 +46,11 @@
android:background="?attr/window_background_color">
<TextView
+ android:id="@+id/explore_overflow_compilations"
+ style="@style/OverflowMenuItem"
+ android:text="@string/offline_compilations_title"/>
+
+ <TextView
android:id="@+id/explore_overflow_settings"
style="@style/OverflowMenuItem"
android:text="@string/settings_item_preferences"/>
--
To view, visit https://gerrit.wikimedia.org/r/366862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f4632c942244f2028a232524bcdb00173def819
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
