Mooeypoo has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366972 )
Change subject: RCFilters: Don't empty the changes list on first load
......................................................................
RCFilters: Don't empty the changes list on first load
jQuery.empty() apparently also unattaches event handlers.
Only empty before we re-append if we are not in the first
load of the changes list.
Bug: T171085
Change-Id: I68754e99a6c5c821be47b1b1e8e22f23db85746c
---
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/72/366972/1
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
index 6512f04..0e9e843 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
@@ -125,7 +125,9 @@
this.$element.append( $message );
} else {
this.$changesListContent = $changesListContent;
- this.$element.empty().append( this.$changesListContent
);
+ if ( !isInitialDOM ) {
+ this.$element.empty().append(
this.$changesListContent );
+ }
// Set up highlight containers
this.setupHighlightContainers( this.$element );
--
To view, visit https://gerrit.wikimedia.org/r/366972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68754e99a6c5c821be47b1b1e8e22f23db85746c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
