Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53584
Change subject: Fix Ifb93e49b
......................................................................
Fix Ifb93e49b
This commit caused a PHP notice if you tried to use diff=prev with an
oldid which was the first revision of the page.
Change-Id: I4c4ccb9a0c8d82e104723a2e72f1c699e2fc249b
---
M includes/diff/DifferenceEngine.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/84/53584/1
diff --git a/includes/diff/DifferenceEngine.php
b/includes/diff/DifferenceEngine.php
index 421bee9..0f3c77f 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -267,6 +267,8 @@
$deleted = $suppressed = false;
$allowed = $this->mNewRev->userCan( Revision::DELETED_TEXT,
$user );
+ $revisionTools = array();
+
# mOldRev is false if the difference engine is called with a
"vague" query for
# a diff between a version V and its previous version V' AND
the version V
# is the first version of that article. In that case, V' does
not exist.
@@ -292,7 +294,6 @@
$samePage = false;
}
- $revisionTools = array();
if ( $samePage && $this->mNewPage->quickUserCan(
'edit', $user ) ) {
if ( $this->mNewRev->isCurrent() &&
$this->mNewPage->userCan( 'rollback', $user ) ) {
$rollbackLink =
Linker::generateRollback( $this->mNewRev, $this->getContext() );
--
To view, visit https://gerrit.wikimedia.org/r/53584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c4ccb9a0c8d82e104723a2e72f1c699e2fc249b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
