Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367218 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Change-Id: I4e8a5fdcfdeb1de4c0941bb187f0d0eee260d42b
---
M composer.json
M includes/JCContent.php
M includes/JCSingleton.php
M includes/JCValue.php
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/JsonConfig
refs/changes/18/367218/1
diff --git a/composer.json b/composer.json
index 4f55859..bf202bf 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
- "mediawiki/mediawiki-codesniffer": "0.10.0"
+ "mediawiki/mediawiki-codesniffer": "0.10.1"
},
"scripts": {
"fix": "phpcbf",
diff --git a/includes/JCContent.php b/includes/JCContent.php
index 418ac79..8128c38 100644
--- a/includes/JCContent.php
+++ b/includes/JCContent.php
@@ -109,7 +109,7 @@
}
/**
- * @return boolean true if thorough validation may be needed -
+ * @return bool true if thorough validation may be needed -
* e.g. rendering HTML or saving new value
*/
public function thorough() {
diff --git a/includes/JCSingleton.php b/includes/JCSingleton.php
index 6359966..ab451b4 100644
--- a/includes/JCSingleton.php
+++ b/includes/JCSingleton.php
@@ -567,7 +567,7 @@
* @deprecated use JCSingleton::parseTitle() instead
*/
public static function getMetadata( $titleValue ) {
- $jct = JCSingleton::parseTitle( $titleValue );
+ $jct = self::parseTitle( $titleValue );
return $jct ? $jct->getConfig() : $jct;
}
diff --git a/includes/JCValue.php b/includes/JCValue.php
index 58364b9..80ae3d5 100644
--- a/includes/JCValue.php
+++ b/includes/JCValue.php
@@ -46,7 +46,7 @@
$this->status( $status );
} elseif ( $this->isMissing() ) {
// Convenience - if we are setting a new value, assume
we are setting a default
- $this->status( JCValue::UNCHECKED );
+ $this->status( self::UNCHECKED );
$this->defaultUsed( true );
}
}
@@ -76,11 +76,11 @@
}
public function isMissing() {
- return $this->status === JCValue::MISSING;
+ return $this->status === self::MISSING;
}
public function isUnchecked() {
- return $this->status === JCValue::UNCHECKED;
+ return $this->status === self::UNCHECKED;
}
/** Helper function - same arguments as wfMessage, or true if message
was already added.
--
To view, visit https://gerrit.wikimedia.org/r/367218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e8a5fdcfdeb1de4c0941bb187f0d0eee260d42b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
