Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367223 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
The following sniffs now pass and were enabled:
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: I2de439cc28b8eba3411e14ffc3da5a59e812096d
---
M composer.json
M lib/LifeWeb/LWItem.php
M phpcs.xml
3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LifeWeb
refs/changes/23/367223/1
diff --git a/composer.json b/composer.json
index 8c9facf..d368985 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.0",
+ "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/lib/LifeWeb/LWItem.php b/lib/LifeWeb/LWItem.php
index f5735c5..74468b4 100644
--- a/lib/LifeWeb/LWItem.php
+++ b/lib/LifeWeb/LWItem.php
@@ -53,7 +53,7 @@
}
*/
- if ( !LWItem::instanceOfCheck( $itemId, $pidInstanceType,
EntityIDs::pid( 'pInstanceOf' ) ) ) {
+ if ( !self::instanceOfCheck( $itemId, $pidInstanceType,
EntityIDs::pid( 'pInstanceOf' ) ) ) {
throw new \MWException( 'Is not an instance.' );
}
@@ -133,7 +133,7 @@
if ( strtolower( $snakID ) == strtolower( $pidProperty
) ) {
$snakValue = $snak->getDataValue();
if ( $snakValue instanceof
\Wikibase\DataModel\Entity\EntityIdValue ) {
- if ( LWItem::instanceOfCheck(
$snakValue->getEntityId(), $pidInstanceType ) ) {
+ if ( self::instanceOfCheck(
$snakValue->getEntityId(), $pidInstanceType ) ) {
$values[] =
$snakValue->getEntityId()->getPrefixedId();
}
}
diff --git a/phpcs.xml b/phpcs.xml
index 4ccfde5..252942b 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -7,7 +7,6 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
- <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
<file>.</file>
<arg name="encoding" value="UTF-8" />
--
To view, visit https://gerrit.wikimedia.org/r/367223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2de439cc28b8eba3411e14ffc3da5a59e812096d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LifeWeb
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
