D3r1ck01 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367320 )
Change subject: Maintain sitelink field if empty on backspace keydown
......................................................................
Maintain sitelink field if empty on backspace keydown
* Ensures that when users hold down the backspace key, the
other sitelink fields should not be deleted the current one is
empty.
* Removed _remoteSitelinkviewIfEmpty function and check if sitelink
view is empty to keep the field.
Bug: T153204
Change-Id: I27cda0716428fe5c287c7344fcc3a70bbe59550c
---
M view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
1 file changed, 0 insertions(+), 39 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/20/367320/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
index c9d6f4f..f71b12e 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
@@ -159,10 +159,6 @@
if ( event.keyCode === $.ui.keyCode.BACKSPACE )
{
var $sitelinkview = $( event.target
).parentsUntil( this ).addBack().filter( '.listview-item' ),
sitelinkview =
listItemAdapter.liInstance( $sitelinkview );
-
- if ( sitelinkview ) {
-
self._removeSitelinkviewIfEmpty( sitelinkview, event ); // FIXME: Move to
sitelinkview
- }
}
} )
.on(
@@ -176,41 +172,6 @@
event.stopPropagation();
}
);
- },
-
- /**
- * @param {jQuery.wikibase.sitelinkview} sitelinkview
- * @param {jQuery.Event} event
- */
- _removeSitelinkviewIfEmpty: function ( sitelinkview, event ) {
- var $sitelinkview = sitelinkview.element,
- listview = this.$listview.data( 'listview' ),
- lia = listview.listItemAdapter(),
- $items = listview.items(),
- isLast = $sitelinkview.get( 0 ) ===
$items.last().get( 0 ),
- isEmpty = sitelinkview.isEmpty()
- || sitelinkview.option( 'value' ) &&
!sitelinkview.value();
-
- if ( isEmpty ) {
- event.preventDefault();
- event.stopPropagation();
-
- // Shift focus to previous line or to following
line if there is no previous:
- $items.each( function ( i ) {
- if ( this === $sitelinkview.get( 0 ) ) {
- if ( i > 0 ) {
- lia.liInstance(
$items.eq( i - 1 ) ).focus();
- } else if ( $items.length > 1 )
{
- lia.liInstance(
$items.eq( i + 1 ) ).focus();
- }
- return false;
- }
- } );
-
- if ( !isLast ) {
- listview.removeItem( $sitelinkview );
- }
- }
},
_updateAutoInput: function () {
--
To view, visit https://gerrit.wikimedia.org/r/367320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27cda0716428fe5c287c7344fcc3a70bbe59550c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: D3r1ck01 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
