jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/367122 )
Change subject: UserPager: Use multiple checkboxes instead of multiselect ...................................................................... UserPager: Use multiple checkboxes instead of multiselect The URL from the serialized form was something like: &wpoptions%5B%5D=editsOnly whereas we needed: &editsOnly=1 Bug: T171332 Change-Id: Iaec223195e121dab83b5605a3dfaffa8e1f93684 --- M includes/specials/pagers/UsersPager.php 1 file changed, 20 insertions(+), 19 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified VolkerE: Looks good to me, but someone else must approve diff --git a/includes/specials/pagers/UsersPager.php b/includes/specials/pagers/UsersPager.php index 7fa03ba..10baadf 100644 --- a/includes/specials/pagers/UsersPager.php +++ b/includes/specials/pagers/UsersPager.php @@ -275,17 +275,6 @@ $groupOptions[ $groupText ] = $group; } - $optionsDefault = []; - if ( $this->editsOnly ) { - $optionsDefault[] = 'editsOnly'; - } - if ( $this->creationSort ) { - $optionsDefault[] = 'creationSort'; - } - if ( $this->mDefaultDirection ) { - $optionsDefault[] = 'desc'; - } - $formDescriptor = [ 'user' => [ 'class' => 'HTMLUserTextField', @@ -300,14 +289,26 @@ 'class' => 'HTMLSelectField', 'options' => $groupOptions, ], - 'options' => [ - 'class' => 'HTMLMultiSelectField', - 'options' => [ - $this->msg( 'listusers-editsonly' )->text() => 'editsOnly', - $this->msg( 'listusers-creationsort' )->text() => 'creationSort', - $this->msg( 'listusers-desc' )->text() => 'desc' - ], - 'default' => $optionsDefault + 'editsOnly' => [ + 'type' => 'check', + 'label' => $this->msg( 'listusers-editsonly' )->text(), + 'name' => 'editsOnly', + 'id' => 'editsOnly', + 'value' => $this->editsOnly + ], + 'creationSort' => [ + 'type' => 'check', + 'label' => $this->msg( 'listusers-creationsort' )->text(), + 'name' => 'creationSort', + 'id' => 'creationSort', + 'value' => $this->creationSort + ], + 'desc' => [ + 'type' => 'check', + 'label' => $this->msg( 'listusers-desc' )->text(), + 'name' => 'desc', + 'id' => 'desc', + 'value' => $this->mDefaultDirection ], 'limithiddenfield' => [ 'class' => 'HTMLHiddenField', -- To view, visit https://gerrit.wikimedia.org/r/367122 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaec223195e121dab83b5605a3dfaffa8e1f93684 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Prtksxna <psax...@wikimedia.org> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: VolkerE <volke...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits