Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367384 )
Change subject: UserPager: Use multiple checkboxes instead of multiselect
......................................................................
UserPager: Use multiple checkboxes instead of multiselect
The URL from the serialized form was something like:
&wpoptions%5B%5D=editsOnly
whereas we needed:
&editsOnly=1
Bug: T171332
Change-Id: Iaec223195e121dab83b5605a3dfaffa8e1f93684
(cherry picked from commit eaefbf99c8183f543c766272fc1a73480d28e004)
---
M includes/specials/pagers/UsersPager.php
1 file changed, 20 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/84/367384/1
diff --git a/includes/specials/pagers/UsersPager.php
b/includes/specials/pagers/UsersPager.php
index 7fa03ba..10baadf 100644
--- a/includes/specials/pagers/UsersPager.php
+++ b/includes/specials/pagers/UsersPager.php
@@ -275,17 +275,6 @@
$groupOptions[ $groupText ] = $group;
}
- $optionsDefault = [];
- if ( $this->editsOnly ) {
- $optionsDefault[] = 'editsOnly';
- }
- if ( $this->creationSort ) {
- $optionsDefault[] = 'creationSort';
- }
- if ( $this->mDefaultDirection ) {
- $optionsDefault[] = 'desc';
- }
-
$formDescriptor = [
'user' => [
'class' => 'HTMLUserTextField',
@@ -300,14 +289,26 @@
'class' => 'HTMLSelectField',
'options' => $groupOptions,
],
- 'options' => [
- 'class' => 'HTMLMultiSelectField',
- 'options' => [
- $this->msg( 'listusers-editsonly'
)->text() => 'editsOnly',
- $this->msg( 'listusers-creationsort'
)->text() => 'creationSort',
- $this->msg( 'listusers-desc' )->text()
=> 'desc'
- ],
- 'default' => $optionsDefault
+ 'editsOnly' => [
+ 'type' => 'check',
+ 'label' => $this->msg( 'listusers-editsonly'
)->text(),
+ 'name' => 'editsOnly',
+ 'id' => 'editsOnly',
+ 'value' => $this->editsOnly
+ ],
+ 'creationSort' => [
+ 'type' => 'check',
+ 'label' => $this->msg( 'listusers-creationsort'
)->text(),
+ 'name' => 'creationSort',
+ 'id' => 'creationSort',
+ 'value' => $this->creationSort
+ ],
+ 'desc' => [
+ 'type' => 'check',
+ 'label' => $this->msg( 'listusers-desc'
)->text(),
+ 'name' => 'desc',
+ 'id' => 'desc',
+ 'value' => $this->mDefaultDirection
],
'limithiddenfield' => [
'class' => 'HTMLHiddenField',
--
To view, visit https://gerrit.wikimedia.org/r/367384
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaec223195e121dab83b5605a3dfaffa8e1f93684
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
