jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/367376 )
Change subject: Removing Explore Similar AB Test
......................................................................
Removing Explore Similar AB Test
Removing Explore Similar AB test code, but
keeping the explore similar event logging around
for any future deployment of this feature.
Bug: T171320
Change-Id: I26a162a6ff88109e29248b2624e10d99f4829647
---
M modules/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 4 insertions(+), 17 deletions(-)
Approvals:
Bearloga: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.wikimediaEvents.searchSatisfaction.js
b/modules/ext.wikimediaEvents.searchSatisfaction.js
index 004f929..07f7849 100644
--- a/modules/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/ext.wikimediaEvents.searchSatisfaction.js
@@ -113,8 +113,8 @@
function initialize( session ) {
var sessionId = session.get( 'sessionId' ),
- // Explore Similar AB test
- validBuckets = [ 'explore_similar_control',
'explore_similar_test' ],
+ // No sub-tests currently running
+ validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname'
),
// Provides a place to handle
wiki-specific sampling,
@@ -136,8 +136,8 @@
subTest: null
},
enwiki: {
- test: 1000,
- subTest: 2
+ test: 2000,
+ subTest: null
},
enwiktionary: {
test: 40,
@@ -688,12 +688,6 @@
);
/**
- * Loading Explore Similar module for A/B test
- */
- if ( session.get( 'subTest' ) ===
'explore_similar_test' ) {
- mw.loader.load( 'ext.cirrus.explore-similar' );
- }
- /**
* Explore similar event logging
* Listens for custom event sent by the Explore Similar
module.
* These events pass along extra data that conforms to
the
@@ -744,13 +738,6 @@
logEvent( 'esclick', esParams );
} );
-
- /**
- * Loading Explore Similar module for A/B test
- */
- if ( session.get( 'subTest' ) ===
'explore_similar_test' ) {
- mw.loader.load( 'ext.cirrus.explore-similar' );
- }
serpExtras = {
offset: $( '.results-info' ).data(
'mw-num-results-offset' )
--
To view, visit https://gerrit.wikimedia.org/r/367376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26a162a6ff88109e29248b2624e10d99f4829647
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Jdrewniak <jdrewn...@wikimedia.org>
Gerrit-Reviewer: Bearloga <mpo...@wikimedia.org>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Jdrewniak <jdrewn...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
