jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/367450 )
Change subject: Add tooltips to buttons in Query Helper toolbar
......................................................................
Add tooltips to buttons in Query Helper toolbar
Change-Id: I43b0384c99b198a2e61673aea1af81749a376049
---
M i18n/en.json
M i18n/qqq.json
M style.css
M wikibase/queryService/ui/queryHelper/QueryHelper.js
4 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Smalyshev: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index 68a2002..1c53fb0 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -61,6 +61,8 @@
"wdqs-dialog-examples-preview-result": "Preview result",
"wdqs-ve-filter": "Filter",
"wdqs-ve-show": "Show",
+ "wdqs-ve-add-label-title": "Add variable containing entity label",
+ "wdqs-ve-remove-row-title": "Remove this row",
"wdqs-ve-with": "with",
"wdqs-ve-anything": "anything",
"wdqs-ve-any": "any",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index ce7e9b6..a9309b5 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -63,6 +63,8 @@
"wdqs-dialog-examples-preview-result": "Label to preview result in
example dialog",
"wdqs-ve-filter": "Label to add a filter in Query
Helper\n{{Identical|Filter}}",
"wdqs-ve-show": "Label to show some item\n{{Identical|Show}}",
+ "wdqs-ve-add-label-title": "Title to add variable containing entity label",
+ "wdqs-ve-remove-row-title": "Title to remove row",
"wdqs-ve-with": "Label item with property\n{{Identical|With}}",
"wdqs-ve-anything": "Label to find anything\n{{Identical|Anything}}",
"wdqs-ve-any": "Label to any property\n{{Identical|Any}}",
diff --git a/style.css b/style.css
index b49afd2..a7cf39b 100644
--- a/style.css
+++ b/style.css
@@ -512,7 +512,7 @@
#query-box .query-helper .toolbar .fa {
font-size: 1.2em;
- display: inherit;
+ display: inline-block;
padding: 0.1em;
}
diff --git a/wikibase/queryService/ui/queryHelper/QueryHelper.js
b/wikibase/queryService/ui/queryHelper/QueryHelper.js
index 82bd50a..3647ef4 100644
--- a/wikibase/queryService/ui/queryHelper/QueryHelper.js
+++ b/wikibase/queryService/ui/queryHelper/QueryHelper.js
@@ -446,6 +446,8 @@
}
return false;
+ } ).tooltip( {
+ title: self._i18n( 'remove-row-title' )
} );
var $label = $( '<a href="#">' ).addClass( 'fa fa-tag' ).click(
function () {
@@ -462,6 +464,8 @@
self._changeListener( self );
}
return false;
+ } ).tooltip( {
+ title: self._i18n( 'add-label-title' )
} );
return $( '<td class="toolbar">' ).append( $label, $delete );
--
To view, visit https://gerrit.wikimedia.org/r/367450
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43b0384c99b198a2e61673aea1af81749a376049
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: WMDE-jand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
