Austinoneil has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367634 )
Change subject: Add ctrl-F and F3 functionality for physical keyboard users
......................................................................
Add ctrl-F and F3 functionality for physical keyboard users
ctrl-F is a fairly ubiquitous keyboard shortcut. F3 is used
in Chrome as well, and would be useful for those with
limited mobility in their hands, or children with small
hands.
Change-Id: I74cb6c8ba551c10b86f567f79b9aa28ea3cd0957
---
M app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpWebViewClient.java
M app/src/main/java/org/wikipedia/page/PageActivity.java
2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/34/367634/1
diff --git
a/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpWebViewClient.java
b/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpWebViewClient.java
index 066830c..3504983 100644
--- a/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpWebViewClient.java
+++ b/app/src/main/java/org/wikipedia/dataclient/okhttp/OkHttpWebViewClient.java
@@ -5,6 +5,7 @@
import android.support.annotation.NonNull;
import android.support.annotation.RequiresApi;
import android.support.annotation.VisibleForTesting;
+import android.view.KeyEvent;
import android.webkit.WebResourceRequest;
import android.webkit.WebResourceResponse;
import android.webkit.WebView;
@@ -121,4 +122,17 @@
inputStream.close();
return new ByteArrayInputStream(sb.toString().getBytes());
}
+
+ @Override
+ public boolean shouldOverrideKeyEvent(WebView view, KeyEvent event) {
+ if(event.isCtrlPressed()) {
+ if(event.getKeyCode() == KeyEvent.KEYCODE_F) {
+ return true;
+ }
+ }
+ else if(event.getKeyCode() == KeyEvent.KEYCODE_F3) {
+ return true;
+ }
+ return false;
+ }
}
diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index eccc44a..dd61c14 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -890,4 +890,21 @@
}
}
}
+
+ @Override
+ public boolean onKeyDown(int keyCode, KeyEvent event) {
+ if(event.isCtrlPressed()) {
+ if (keyCode == KeyEvent.KEYCODE_F) {
+ pageFragment.showFindInPage();
+ return true;
+ }
+ }
+ else {
+ if(keyCode == KeyEvent.KEYCODE_F3) {
+ pageFragment.showFindInPage();
+ return true;
+ }
+ }
+ return super.onKeyDown(keyCode, event);
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/367634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74cb6c8ba551c10b86f567f79b9aa28ea3cd0957
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Austinoneil <austin.m.on...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
