Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53628


Change subject: Replace weird usage of explode
......................................................................

Replace weird usage of explode

Change-Id: Ic4021be695c9ed15dea0da0e94967a0d7d441670
---
M includes/ChangesList.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/28/53628/1

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 8461001..e485d79 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -121,8 +121,10 @@
         */
        private function preCacheMessages() {
                if( !isset( $this->message ) ) {
-                       foreach ( explode( ' ', 'cur diff hist last blocklink 
history ' .
-                       'semicolon-separator pipe-separator' ) as $msg ) {
+                       foreach ( array(
+                               'cur', 'diff', 'hist', 'last', 'blocklink', 
history',
+                               'semicolon-separator', 'pipe-separator' ) as 
$msg
+                       ) {
                                $this->message[$msg] = $this->msg( $msg 
)->escaped();
                        }
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/53628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4021be695c9ed15dea0da0e94967a0d7d441670
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to