Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367850 )
Change subject: RCFilters: Followup I78e23f85c3: Don't disable RCFilters system
when fetching results
......................................................................
RCFilters: Followup I78e23f85c3: Don't disable RCFilters system when fetching
results
We disable and hide it only on first page load while we create the
system, but should not hide and disable the actual filter area
system.
Bug: T165286
Bug: T171671
Change-Id: Ifc9d3c02c0c118d48634b8df846e14bfa6ea294a
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
3 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/50/367850/1
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
index 4263c51..e758f26 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
@@ -36,6 +36,7 @@
$( '.rcfilters-container' ).append(
filtersWidget.$element );
$( 'body' ).append( $overlay );
+ $( '.rcfilters-head' ).addClass(
'mw-rcfilters-ui-ready' );
$( 'a.mw-helplink' ).attr(
'href',
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
index 37dda4d..c2533df 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
@@ -76,7 +76,6 @@
* Respond to changes list model invalidate
*/
mw.rcfilters.ui.ChangesListWrapperWidget.prototype.onModelInvalidate =
function () {
- $( '.rcfilters-head' ).removeClass( 'mw-rcfilters-ui-ready' );
$( '.rcfilters-spinner' ).removeClass( 'mw-rcfilters-ui-ready'
);
this.$element.removeClass( 'mw-rcfilters-ui-ready' );
};
@@ -138,7 +137,6 @@
}
}
- $( '.rcfilters-head' ).addClass( 'mw-rcfilters-ui-ready' );
$( '.rcfilters-spinner' ).addClass( 'mw-rcfilters-ui-ready' );
this.$element.addClass( 'mw-rcfilters-ui-ready' );
};
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
index 04ccaf6..ee8e0bc 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
@@ -87,6 +87,7 @@
*/
mw.rcfilters.ui.FormWrapperWidget.prototype.onChangesModelInvalidate =
function () {
this.$submitButton.prop( 'disabled', true );
+ this.$element.removeClass( 'mw-rcfilters-ui-ready' );
};
/**
@@ -99,6 +100,7 @@
*/
mw.rcfilters.ui.FormWrapperWidget.prototype.onChangesModelUpdate =
function ( $changesList, $fieldset, isInitialDOM ) {
this.$submitButton.prop( 'disabled', false );
+ this.$element.removeClass( 'mw-rcfilters-ui-ready' );
// Replace the entire fieldset
this.$element.empty().append( $fieldset.contents() );
--
To view, visit https://gerrit.wikimedia.org/r/367850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc9d3c02c0c118d48634b8df846e14bfa6ea294a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.11
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
