Giuseppe Lavagetto has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367870 )
Change subject: hiera: fix mwcache library
......................................................................
hiera: fix mwcache library
Change-Id: I26f934a0c543cceff8a05c34dd0b9f650d9da465
---
M modules/wmflib/lib/hiera/mwcache.rb
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/70/367870/1
diff --git a/modules/wmflib/lib/hiera/mwcache.rb
b/modules/wmflib/lib/hiera/mwcache.rb
index 56f5575..6f1ebb1 100644
--- a/modules/wmflib/lib/hiera/mwcache.rb
+++ b/modules/wmflib/lib/hiera/mwcache.rb
@@ -28,7 +28,8 @@
end
end
- def read(path, expected_type, default = nil, &_block)
+ # rubocop: disable Lint/UnusedMethodArgument
+ def read(path, expected_type, default = nil, &block)
read_file(path, expected_type)
rescue Hiera::MediawikiPageNotFoundError => detail
# Any errors other than this will cause hiera to raise an error and
puppet to fail.
@@ -40,7 +41,7 @@
raise error
end
- def read_file(path, expected_type = Object)
+ def read_file(path, expected_type = Object, &block)
if stale?(path)
resp = get_from_mediawiki(path, true)
data = resp["*"]
@@ -53,6 +54,7 @@
@cache[path][:data]
end
+ # rubocop: enable Lint/Unusedmethodargument
private
--
To view, visit https://gerrit.wikimedia.org/r/367870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26f934a0c543cceff8a05c34dd0b9f650d9da465
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
