jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366825 )
Change subject: Simplify addReportsToStatement, addParameterReports
......................................................................
Simplify addReportsToStatement, addParameterReports
buildReport no longer returns null, and buildParameterReport never did,
so we can simply use Array.map.
Change-Id: I0bcfc1ae8a792b37c1c283304ddaea5c3d8f14f2
---
M modules/gadget.js
1 file changed, 2 insertions(+), 19 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/gadget.js b/modules/gadget.js
index d10b811..a49f3d4 100644
--- a/modules/gadget.js
+++ b/modules/gadget.js
@@ -56,8 +56,6 @@
propertyId = $statement.parents(
'.wikibase-statementgroupview' )[ 0 ].id,
results,
reports,
- i,
- report,
list,
$target;
@@ -66,14 +64,7 @@
}
results = entityData[ propertyId ][ statementId ];
- reports = [];
-
- for( i = 0; i < results.length; i++ ) {
- report = buildReport( results[ i ] );
- if ( report !== null ) {
- reports.push( report );
- }
- }
+ reports = results.map( buildReport );
list =
wikibase.quality.constraints.ui.ConstraintReportList.static.fromPanels(
reports,
@@ -112,8 +103,6 @@
status,
problems,
reports,
- i,
- report,
list,
$statement,
$target;
@@ -125,13 +114,7 @@
}
problems = parameterReports[ constraintId ].problems;
- reports = [];
- for ( i = 0; i < problems.length; i++ ) {
- report = buildParameterReport( problems[ i ] );
- if ( report !== null ) {
- reports.push( report );
- }
- }
+ reports = problems.map( buildParameterReport );
list = new
wikibase.quality.constraints.ui.ConstraintReportList( {
items: [
--
To view, visit https://gerrit.wikimedia.org/r/366825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bcfc1ae8a792b37c1c283304ddaea5c3d8f14f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
