jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/356071 )
Change subject: Don't show suggestions for qualifiers/references of new
statements
......................................................................
Don't show suggestions for qualifiers/references of new statements
When you focus a new qualifier of a new statement, the suggestions
are same as for the new statement. This patch doesn't fix the problem
but suppresses the wrong suggestions.
Bug: T102324
Change-Id: I3ea5fca4ecb88d5c068f97a08d8f455e4b9ec74f
---
M modules/ext.PropertySuggester.EntitySelector.js
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
Lucas Werkmeister (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ext.PropertySuggester.EntitySelector.js
b/modules/ext.PropertySuggester.EntitySelector.js
index 1fc0979..a999ba3 100644
--- a/modules/ext.PropertySuggester.EntitySelector.js
+++ b/modules/ext.PropertySuggester.EntitySelector.js
@@ -92,7 +92,9 @@
_useSuggester: function () {
var entity = this._getEntity();
- return this.options.type === 'property' && entity &&
entity.getType() === 'item';
+ return this.options.type === 'property' &&
+ entity && entity.getType() === 'item' &&
+ this._getPropertyContext() !== null;
},
/**
@@ -154,14 +156,16 @@
*/
_getPropertyContext: function () {
if ( this._isInNewStatementView() ) {
- return 'item';
+ if ( !this._isQualifier() &&
!this._isReference() ) {
+ return 'item';
+ }
} else if ( this._isQualifier() ) {
return 'qualifier';
} else if ( this._isReference() ) {
return 'reference';
- } else {
- return null;
}
+
+ return null;
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/356071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ea5fca4ecb88d5c068f97a08d8f455e4b9ec74f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PropertySuggester
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
