Mforns has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367832 )

Change subject: Correcting possible null pointer exception
......................................................................


Correcting possible null pointer exception

Tested code on 1002 together with general tagging

Bug: T164021
Change-Id: Ida22d1cbebd0b48bdc41e4029a01996448e0aab7
---
M 
refinery-core/src/main/java/org/wikimedia/analytics/refinery/core/webrequest/WebrequestData.java
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Mforns: Verified; Looks good to me, approved



diff --git 
a/refinery-core/src/main/java/org/wikimedia/analytics/refinery/core/webrequest/WebrequestData.java
 
b/refinery-core/src/main/java/org/wikimedia/analytics/refinery/core/webrequest/WebrequestData.java
index 4b5abb9..c70e2ed 100644
--- 
a/refinery-core/src/main/java/org/wikimedia/analytics/refinery/core/webrequest/WebrequestData.java
+++ 
b/refinery-core/src/main/java/org/wikimedia/analytics/refinery/core/webrequest/WebrequestData.java
@@ -21,7 +21,14 @@
     public WebrequestData(String uriHost, String uriPath, String uriQuery,
                           String httpStatus, String contentType, String 
userAgent,
                           String rawXAnalyticsHeader){
-        this.uriHost = uriHost.toLowerCase().trim();
+
+
+        if (uriHost != null) {
+            this.uriHost = uriHost.toLowerCase().trim();
+        } else {
+            this.uriHost = uriHost;
+        }
+
         this.uriPath = uriPath;
         this.uriQuery = uriQuery;
         this.httpStatus = httpStatus;

-- 
To view, visit https://gerrit.wikimedia.org/r/367832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida22d1cbebd0b48bdc41e4029a01996448e0aab7
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery/source
Gerrit-Branch: master
Gerrit-Owner: Nuria <[email protected]>
Gerrit-Reviewer: Joal <[email protected]>
Gerrit-Reviewer: Mforns <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to