Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368121 )
Change subject: Make tests compatible with QUnit 2
......................................................................
Make tests compatible with QUnit 2
Avoid QUnit.asyncTest, QUnit.start/stop (deprecated in 1.x, removed in 2.0).
Bug: T170515
Change-Id: I15fc0b75832308cf7865e79b8156432717063631
---
M tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/data-values/value-view
refs/changes/21/368121/1
diff --git a/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
b/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
index 14b2271..522deed 100644
--- a/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
+++ b/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
@@ -39,8 +39,9 @@
assert.equal( listrotator.getValue(), 'custom value' );
} );
- QUnit.asyncTest( 'supports switching away from custom values',
function( assert ) {
+ QUnit.test( 'supports switching away from custom values', function(
assert ) {
assert.expect( 2 );
+ var done = assert.async();
var onValueChange = sinon.spy();
var upstreamValue = {
custom: true,
@@ -67,7 +68,7 @@
sinon.assert.calledOnce( onValueChange );
assert.equal( listrotator.getValue(), 'fixed value' );
- QUnit.start();
+ done();
}, 200 );
} );
--
To view, visit https://gerrit.wikimedia.org/r/368121
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15fc0b75832308cf7865e79b8156432717063631
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
