jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366833 )
Change subject: Remove generic CSS class `lemma-widget_control`
......................................................................
Remove generic CSS class `lemma-widget_control`
Used LESS mixin instead - provides better maintainability and makes
markup more semantic oriented.
Change-Id: I13c72047507475ee23973fd1e94c6285e67e1ab0
---
M resources/lemma-widget.less
M src/View/LexemeView.php
2 files changed, 16 insertions(+), 14 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/lemma-widget.less b/resources/lemma-widget.less
index b48b108..02bec88 100644
--- a/resources/lemma-widget.less
+++ b/resources/lemma-widget.less
@@ -41,17 +41,6 @@
align-items: flex-start;
}
- &_control {
- background: transparent;
- border: none;
- cursor: pointer;
- color: #0d4c99;
- }
-
- &_control:hover {
- text-decoration: underline;
- }
-
.prepend-with-wikibase-oojs-icon(@image) {
&:before {
content:'';
@@ -81,13 +70,26 @@
}
}
+ .button-displayed-as-link() {
+ background: transparent;
+ border: none;
+ cursor: pointer;
+ color: #0d4c99;
+ &:hover {
+ text-decoration: underline;
+ }
+ }
+
&_edit {
+ .button-displayed-as-link;
.prepend-with-wikibase-oojs-icon('edit-ltr.png');
}
&_save {
+ .button-displayed-as-link;
.prepend-with-wikibase-oojs-icon('check.png');
}
&_cancel {
+ .button-displayed-as-link;
.prepend-with-wikibase-oojs-icon('close-ltr.png');
}
diff --git a/src/View/LexemeView.php b/src/View/LexemeView.php
index 6b00945..9d1e276 100644
--- a/src/View/LexemeView.php
+++ b/src/View/LexemeView.php
@@ -272,11 +272,11 @@
</ul>
</div>
<div class="lemma-widget_controls">
- <button type="button" class="lemma-widget_control
lemma-widget_edit" v-if="!inEditMode"
+ <button type="button" class="lemma-widget_edit"
v-if="!inEditMode"
:disabled="isSaving"
v-on:click="edit">{{'wikibase-edit'|message}}</button>
- <button type="button" class="lemma-widget_control
lemma-widget_save" v-if="inEditMode"
+ <button type="button" class="lemma-widget_save"
v-if="inEditMode"
:disabled="isSaving"
v-on:click="save">{{'wikibase-save'|message}}</button>
- <button type="button" class="lemma-widget_control
lemma-widget_cancel" v-if="inEditMode"
+ <button type="button" class="lemma-widget_cancel"
v-if="inEditMode"
:disabled="isSaving"
v-on:click="cancel">{{'wikibase-cancel'|message}}</button>
</div>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/366833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13c72047507475ee23973fd1e94c6285e67e1ab0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
