Gehel has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368212 )

Change subject: r: Remove libicu dependency
......................................................................


r: Remove libicu dependency

Change-Id: Icd738f5aebb6f84c85573c81ff8aa6315b30202a
---
M modules/r/manifests/init.pp
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Gehel: Looks good to me, approved



diff --git a/modules/r/manifests/init.pp b/modules/r/manifests/init.pp
index 8e18d01..91a355f 100644
--- a/modules/r/manifests/init.pp
+++ b/modules/r/manifests/init.pp
@@ -41,12 +41,11 @@
 
     if $devtools {
         $devtools_essentials = [
-            'git-core',
-            'libxml2',
-            'libssl-dev',
-            'libcurl4-openssl-dev',
-            'libicu-dev',
-            'libssh2-1-dev'
+            'git-core',             # for git2r
+            'libxml2',              # for xml2
+            'libssl-dev',           # for openssl
+            'libcurl4-openssl-dev', # for curl
+            'libssh2-1-dev'         # for git2r
         ]
         require_package($devtools_essentials)
 
@@ -57,8 +56,7 @@
         $r_packages = [
             'xml2',
             'curl',
-            'testthat',
-            'devtools'
+            'devtools',
         ]
         r::cran { $r_packages:
             require => [

-- 
To view, visit https://gerrit.wikimedia.org/r/368212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd738f5aebb6f84c85573c81ff8aa6315b30202a
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Bearloga <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to