jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366857 )
Change subject: Allow line breaking at underscores in variables
......................................................................
Allow line breaking at underscores in variables
Also fixes bug for unnecessary API call for variables
Change-Id: I2e0b9a70fc233f19e4327668a519393748d70aed
---
M wikibase/queryService/ui/queryHelper/QueryHelper.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Smalyshev: Looks good to me, approved
Lucas Werkmeister (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/wikibase/queryService/ui/queryHelper/QueryHelper.js
b/wikibase/queryService/ui/queryHelper/QueryHelper.js
index d2fbb0a..a642694 100644
--- a/wikibase/queryService/ui/queryHelper/QueryHelper.js
+++ b/wikibase/queryService/ui/queryHelper/QueryHelper.js
@@ -413,7 +413,9 @@
if ( self._isSimpleMode ) {
return;
}
- entity = entity.replace( '?', '' );
+ entity = entity.replace( '?', '' ).replace(
/_/g, '_<wbr>' );
+ $triple.append( $( '<td>' ).append( entity ) );
+ return;
}
if ( entity.type && entity.type === 'path' ) {
--
To view, visit https://gerrit.wikimedia.org/r/366857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e0b9a70fc233f19e4327668a519393748d70aed
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
