Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368323 )
Change subject: Enable jsduck for resources/src/mediawiki.rcfilters and make
pass
......................................................................
Enable jsduck for resources/src/mediawiki.rcfilters and make pass
Change-Id: I2a29689e2697108a5c5206cc61b36b5fb838182f
---
M jsduck.json
M maintenance/jsduck/categories.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
17 files changed, 23 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/23/368323/1
diff --git a/jsduck.json b/jsduck.json
index f7771d1..cbd4676 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -16,6 +16,7 @@
"resources/src/mediawiki.action",
"resources/src/mediawiki.language",
"resources/src/mediawiki.messagePoster",
+ "resources/src/mediawiki.rcfilters",
"resources/src/mediawiki.special",
"resources/src/mediawiki.toolbar",
"resources/src/mediawiki.widgets",
diff --git a/maintenance/jsduck/categories.json
b/maintenance/jsduck/categories.json
index 2c8c8b0..899d80d 100644
--- a/maintenance/jsduck/categories.json
+++ b/maintenance/jsduck/categories.json
@@ -66,7 +66,8 @@
"mw.Upload*",
"mw.ForeignUpload",
"mw.ForeignStructuredUpload*",
- "mw.GallerySlideshow"
+ "mw.GallerySlideshow",
+ "mw.rcfilters*"
]
},
{
diff --git
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index 3281735..4ea1e03 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -634,7 +634,7 @@
/**
* Get the highlight parameters based on current filter configuration
*
- * @return {Object} Object where keys are "<filter name>_color" and
values
+ * @return {Object} Object where keys are `<filter name>_color` and
values
* are the selected highlight colors.
*/
mw.rcfilters.dm.FiltersViewModel.prototype.getHighlightParameters =
function () {
@@ -656,7 +656,7 @@
*
* @param {Object} representation Object containing representation of
* some or all highlight values
- * @return {Object} Object where keys are "<filter name>_color" and
values
+ * @return {Object} Object where keys are `<filter name>_color` and
values
* are the selected highlight colors. The returned
object
* contains all available filters either with a color
value
* or with null.
diff --git
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
index 8536570..29134a5 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
@@ -2,6 +2,7 @@
/**
* View model for saved queries
*
+ * @class
* @mixins OO.EventEmitter
* @mixins OO.EmitterList
*
diff --git
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index 729aee3..c066a1f 100644
---
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
@@ -2,6 +2,7 @@
/**
* View model for a single saved query
*
+ * @class
* @mixins OO.EventEmitter
*
* @constructor
@@ -31,7 +32,7 @@
/* Events */
/**
- * @update
+ * @event update
*
* Model has been updated
*/
@@ -63,7 +64,7 @@
/**
* Get query label
*
- * @return {label} Query label
+ * @return {string} Query label
*/
mw.rcfilters.dm.SavedQueryItemModel.prototype.getLabel = function () {
return this.label;
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 82213ea..a7c42fe 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -889,7 +889,7 @@
* Track usage of highlight feature
*
* @param {string} action
- * @param {array|object|string} filters
+ * @param {Array|Object|string} filters
*/
mw.rcfilters.Controller.prototype._trackHighlight = function ( action,
filters ) {
filters = typeof filters === 'string' ? { name: filters } :
filters;
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
index ebeaad6..1c5bb54 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
@@ -3,6 +3,7 @@
* Supported highlight colors.
* Warning: These are also hardcoded in
"styles/mw.rcfilters.variables.less"
*
+ * @class mw.rcfilters
* @type {string[]}
*/
mw.rcfilters.HighlightColors = [ 'c1', 'c2', 'c3', 'c4', 'c5' ];
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.js
index 8cea27e..757e2ab 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.js
@@ -1,4 +1,7 @@
( function ( mw ) {
+ /**
+ * @class
+ */
mw.rcfilters = {
dm: {},
ui: {},
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
index 61ee4a5..86d74bf 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
@@ -2,6 +2,7 @@
/**
* Widget defining the button controlling the popup for the number of
results
*
+ * @class
* @extends OO.ui.Widget
*
* @constructor
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
index 1569f38..870aef7 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
@@ -2,6 +2,7 @@
/**
* Widget defining the button controlling the popup for the date range
for the results
*
+ * @class
* @extends OO.ui.Widget
*
* @constructor
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
index 835cec8..7426123 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
@@ -52,7 +52,6 @@
/**
* @static
- * @inheritdoc
*/
mw.rcfilters.ui.FilterItemHighlightButton.static.cancelButtonMouseDownEvents =
true;
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
index da71d70..eeb5ddc 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
@@ -2,6 +2,7 @@
/**
* Menu header for the RCFilters filters menu
*
+ * @class
* @extends OO.ui.Widget
*
* @constructor
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
index 88479c3..e053914 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
@@ -2,6 +2,7 @@
/**
* A widget representing a menu section for filter groups
*
+ * @class
* @extends OO.ui.MenuSectionOptionWidget
*
* @constructor
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index 6a6790f..ac22258 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@ -2,6 +2,7 @@
/**
* List displaying all filter groups
*
+ * @class
* @extends OO.ui.MenuTagMultiselectWidget
* @mixins OO.ui.mixin.PendingElement
*
@@ -321,7 +322,7 @@
};
/**
- * @inheridoc
+ * @inheritdoc
*/
mw.rcfilters.ui.FilterTagMultiselectWidget.prototype.onChangeTags =
function () {
// Parent method
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index b6b20ee..cac1059 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -2,6 +2,7 @@
/**
* Quick links menu option widget
*
+ * @class
* @extends OO.ui.Widget
* @mixins OO.ui.mixin.LabelElement
* @mixins OO.ui.mixin.IconElement
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
index 27a21d6..7eda90a 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
@@ -2,6 +2,7 @@
/**
* Quick links widget
*
+ * @class
* @extends OO.ui.Widget
*
* @constructor
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
index 7045ab6..ac0e50d 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
@@ -3,6 +3,7 @@
* Widget defining the behavior used to choose from a set of values
* in a single_value group
*
+ * @class
* @extends OO.ui.Widget
* @mixins OO.ui.mixin.LabelElement
*
--
To view, visit https://gerrit.wikimedia.org/r/368323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a29689e2697108a5c5206cc61b36b5fb838182f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
