DCausse has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368400 )
Change subject: Minor cleanups in feature.py
......................................................................
Minor cleanups in feature.py
Change-Id: I68cbe956de4dcd8d2296939113343b4f25e25c98
---
M mjolnir/features.py
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/search/MjoLniR
refs/changes/00/368400/1
diff --git a/mjolnir/features.py b/mjolnir/features.py
index 60265fd..5b2f30f 100644
--- a/mjolnir/features.py
+++ b/mjolnir/features.py
@@ -670,6 +670,7 @@
for row in rows:
req = log_query.make_msearch(row, indices)
url, response = mjolnir.cirrus.make_request(session, url,
url_list, req)
+ assert response.status_code == 200
parsed = json.loads(response.text)
assert 'responses' in parsed, response.text
resp = parsed['responses'][0]
@@ -711,12 +712,10 @@
indices = {}
eltType, name, store = _explode_ltr_model_definition(model)
log_query = LtrLoggingQuery(eltType, name, store)
- Response = namedtuple('Response', ['status_code', 'text'])
def kafka_handle_response(record):
- response = Response(record['status_code'], record['text'])
- parsed = json.loads(response.text)
- assert 'responses' in parsed, response.text
+ assert record['status_code'] == 200
+ parsed = json.loads(record['text'])
response = parsed['responses'][0]
for hit_page_id, features in extract_ltr_log_feature_values(response,
feature_names_accu):
--
To view, visit https://gerrit.wikimedia.org/r/368400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68cbe956de4dcd8d2296939113343b4f25e25c98
Gerrit-PatchSet: 1
Gerrit-Project: search/MjoLniR
Gerrit-Branch: master
Gerrit-Owner: DCausse <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
