Giuseppe Lavagetto has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368438 )

Change subject: Do not filter catalogs if they have not compiled.
......................................................................

Do not filter catalogs if they have not compiled.

Change-Id: Ic3c0787c80353db8ce0033eb846819b20daa4b2e
---
M puppet_compiler/worker.py
1 file changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/software/puppet-compiler 
refs/changes/38/368438/1

diff --git a/puppet_compiler/worker.py b/puppet_compiler/worker.py
index 42ab22f..1f5406b 100644
--- a/puppet_compiler/worker.py
+++ b/puppet_compiler/worker.py
@@ -208,12 +208,15 @@
         ]
         args = []
         errors = self.E_OK
-        if not self._compile(self._envs[0], args):
+        if self._compile(self._envs[0], args):
+            _log.info("Filtering the change catalog (%s)", self.hostname)
+            self.filter_change.run()
+        else:
             errors += self.E_BASE
-        if not self._compile(self._envs[1], future_args):
+        if self._compile(self._envs[1], future_args):
+            _log.info("Filtering the future catalog (%s)", self.hostname)
+            self.filter_future.run()
+        else:
             errors += self.E_CHANGED
-        _log.info("Filtering the future catalog (%s)", self.hostname)
-        self.filter_change.run()
-        self.filter_future.run()
 
         return errors

-- 
To view, visit https://gerrit.wikimedia.org/r/368438
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3c0787c80353db8ce0033eb846819b20daa4b2e
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/puppet-compiler
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to