Andrew Bogott has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/368595 )
Change subject: Do not clobber $out in local scope
......................................................................
Do not clobber $out in local scope
A refactor and a revert combined to make `$out` in the local scope used
for both an object and a string.
Bug: T172077
Change-Id: Ibcab17f82b7454b607329ced112257b43856c15e
---
M special/SpecialNovaRole.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Andrew Bogott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/special/SpecialNovaRole.php b/special/SpecialNovaRole.php
index 768de0a..8e1a7d0 100644
--- a/special/SpecialNovaRole.php
+++ b/special/SpecialNovaRole.php
@@ -269,13 +269,13 @@
}
}
- $out = '<br />';
+ $outHtml = '<br />';
$returnto = Title::newFromText( $formData['returnto'] );
- $out .= Linker::link(
+ $outHtml .= Linker::link(
$returnto,
$this->msg( 'openstackmanager-backprojectlist'
)->escaped()
);
- $out->addHTML( $out );
+ $out->addHTML( $outHtml );
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/368595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcab17f82b7454b607329ced112257b43856c15e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
