jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/368797 )
Change subject: Tweak demo data:
......................................................................
Tweak demo data:
* fix a type
* rename "related concept" to "evokes"
* introduce "denotes" relation
Change-Id: If19ca109b5fc210937750588aaf165981d2249b6
---
M src/DemoData/AskOut1Populator.php
M src/DemoData/HardLexemePopulator.php
M src/DemoData/Id.php
M src/DemoData/LeiterLexemePopulator.php
4 files changed, 19 insertions(+), 5 deletions(-)
Approvals:
Aleksey Bekh-Ivanov (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/DemoData/AskOut1Populator.php
b/src/DemoData/AskOut1Populator.php
index 930851a..e0944c1 100644
--- a/src/DemoData/AskOut1Populator.php
+++ b/src/DemoData/AskOut1Populator.php
@@ -19,7 +19,7 @@
*/
private function buildDefaultSense() {
return NewSense::havingId( 'S5' )
- ->withGloss( 'en', 'To ask somebody out’: To request a
romantic date' )
+ ->withGloss( 'en', '’To ask somebody out’: To request a
romantic date' )
->build();
}
diff --git a/src/DemoData/HardLexemePopulator.php
b/src/DemoData/HardLexemePopulator.php
index 2f49593..5581663 100644
--- a/src/DemoData/HardLexemePopulator.php
+++ b/src/DemoData/HardLexemePopulator.php
@@ -116,17 +116,17 @@
->withGloss( 'en', 'resisting deformation' )
->withGloss( 'de', 'schwer verformbar' )
->withStatement(
- NewStatement::forProperty(
Id::P_RELATED_CONCEPT )
+ NewStatement::forProperty( Id::P_EVOKES )
->withValue( new ItemId(
Id::Q_ELASTICITY ) )
->withSomeGuid()
)
->withStatement(
- NewStatement::forProperty(
Id::P_RELATED_CONCEPT )
+ NewStatement::forProperty( Id::P_EVOKES )
->withValue( new ItemId(
Id::Q_DUCTILITY ) )
->withSomeGuid()
)
->withStatement(
- NewStatement::forProperty(
Id::P_RELATED_CONCEPT )
+ NewStatement::forProperty( Id::P_EVOKES )
->withValue( new ItemId( Id::Q_HARDNESS
) )
->withSomeGuid()
)
diff --git a/src/DemoData/Id.php b/src/DemoData/Id.php
index 6631dea..b4b3b0f 100644
--- a/src/DemoData/Id.php
+++ b/src/DemoData/Id.php
@@ -33,12 +33,14 @@
const P_REGION = 'P11';
const P_PRONUNCIATION_AUDIO = 'P12';
const P_REGISTER = 'P13';
- const P_RELATED_CONCEPT = 'P14';
+ const P_EVOKES = 'P14';
const P_MORPHOLOGY = 'P15';
const P_GRAMMATICAL_GENDER = 'P16';
const P_GENDERED_FORM = 'P17';
const P_SYLLABIFICATION = 'P18';
const P_GRAMMATICAL_FRAME = 'P19';
+ const P_DENOTES = 'P26';
+
// Form type
const P_RHYME = 'P20';
//Sense type
@@ -47,6 +49,8 @@
const P_ANTONYM = 'P24';
const P_REFERS_TO_SENSE = 'P25';
+ const Q_CONDUCTOR = 'Q33';
+ const Q_LEADER = 'Q32';
const Q_VERBAL_PHRASE = 'Q31';
const Q_FEMALE = 'Q30';
const Q_GENITIVE = 'Q29';
diff --git a/src/DemoData/LeiterLexemePopulator.php
b/src/DemoData/LeiterLexemePopulator.php
index f3093a6..af505ea 100644
--- a/src/DemoData/LeiterLexemePopulator.php
+++ b/src/DemoData/LeiterLexemePopulator.php
@@ -72,6 +72,11 @@
return NewSense::havingId( 'S1' )
->withGloss( 'de', 'Führungsperson' )
->withGloss( 'en', 'leader' )
+ ->withStatement(
+ NewStatement::forProperty( Id::P_DENOTES )
+ ->withValue( Id::Q_LEADER )
+ ->withSomeGuid()
+ )
->build();
}
@@ -82,6 +87,11 @@
return NewSense::havingId( 'S2' )
->withGloss( 'de', 'elektrischer Leiter' )
->withGloss( 'en', 'electrical conductor' )
+ ->withStatement(
+ NewStatement::forProperty( Id::P_DENOTES )
+ ->withValue( Id::Q_CONDUCTOR )
+ ->withSomeGuid()
+ )
->build();
}
--
To view, visit https://gerrit.wikimedia.org/r/368797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If19ca109b5fc210937750588aaf165981d2249b6
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <aleksey.bekh-iva...@wikimedia.de>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
