jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/368825 )
Change subject: Don't throw an exception if observed annotation is alien to us
......................................................................
Don't throw an exception if observed annotation is alien to us
Bug: T165746
Change-Id: Ic4ea1d5bde29f77d0b62e7fc99df151674864bce
---
M src/ce/ve.ce.TextState.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ce/ve.ce.TextState.js b/src/ce/ve.ce.TextState.js
index 7459b31..ddc5a08 100644
--- a/src/ce/ve.ce.TextState.js
+++ b/src/ce/ve.ce.TextState.js
@@ -396,7 +396,7 @@
modelClass = ve.dm.modelRegistry.lookup(
ve.dm.modelRegistry.matchElement( element )
);
- if ( !( modelClass.prototype instanceof
ve.dm.Annotation ) ) {
+ if ( !( modelClass &&
modelClass.prototype instanceof ve.dm.Annotation ) ) {
// Erroneous element; nothing
we can do with it
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/368825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ea1d5bde29f77d0b62e7fc99df151674864bce
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
