jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/368585 )
Change subject: Show title on the page named '0'
......................................................................
Show title on the page named '0'
The string '0' evals to false in the if( $pageTitle ) condition, hence
the title was not shown for the page named '0'.
Bug: T163084
Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464
---
M includes/skins/SkinMinerva.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Pmiazga: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 83af2fc..31cedd0 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -797,7 +797,8 @@
$heading =
$this->getUserPageHelper()->getPageUser()->getName();
} else {
$pageTitle = $this->getOutput()->getPageTitle();
- if ( $pageTitle ) {
+ // Loose comparison with '!=' is intentional, to catch
null and false too, but not '0'
+ if ( $pageTitle != '' ) {
$heading = $pageTitle;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/368585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: EddieGP <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
