jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/368836 )
Change subject: Follow-up b446a3b9: don't auto-close DateInputWidget too early
......................................................................
Follow-up b446a3b9: don't auto-close DateInputWidget too early
Clicking on a month does not mean that the user has made a selection,
it only means that if we are in { precision: 'month' } mode.
In { precision: 'day' } mode, clicking a month is navigational,
so don't auto-close in that case.
Bug: T172041
Change-Id: I16a3e15a3b69844ff866fc09ba6a9268e85b2930
---
M resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js
index ce9cf36..f10c93d 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js
@@ -575,13 +575,13 @@
* @return {boolean} False to cancel the default event
*/
mw.widgets.DateInputWidget.prototype.onCalendarClick = function ( e ) {
+ var targetClass = this.calendar.getPrecision() === 'month' ?
+ 'mw-widget-calendarWidget-month' :
+ 'mw-widget-calendarWidget-day';
if (
!this.isDisabled() &&
e.which === 1 &&
- (
- $( e.target ).hasClass(
'mw-widget-calendarWidget-day' ) ||
- $( e.target ).hasClass(
'mw-widget-calendarWidget-month' )
- )
+ $( e.target ).hasClass( targetClass )
) {
this.deactivate( true );
return false;
--
To view, visit https://gerrit.wikimedia.org/r/368836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16a3e15a3b69844ff866fc09ba6a9268e85b2930
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
