Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368944 )
Change subject: Feed design tweaks, pt. 1: adjust card margins
......................................................................
Feed design tweaks, pt. 1: adjust card margins
Bug: T171328
Change-Id: I005289dfd3ae57e06e10deed4ff84a7633795801
---
M app/src/main/java/org/wikipedia/feed/view/FeedView.java
M app/src/main/res/values/dimens.xml
2 files changed, 13 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/44/368944/1
diff --git a/app/src/main/java/org/wikipedia/feed/view/FeedView.java
b/app/src/main/java/org/wikipedia/feed/view/FeedView.java
index e469bae..1ebad05 100644
--- a/app/src/main/java/org/wikipedia/feed/view/FeedView.java
+++ b/app/src/main/java/org/wikipedia/feed/view/FeedView.java
@@ -16,9 +16,17 @@
import org.wikipedia.views.ItemTouchHelperSwipeAdapter;
import org.wikipedia.views.MarginItemDecoration;
+import static org.wikipedia.util.DimenUtil.getDimension;
+import static org.wikipedia.util.DimenUtil.roundedDpToPx;
+
public class FeedView extends AutoFitRecyclerView {
+
private StaggeredGridLayoutManager recyclerLayoutManager;
@Nullable private ItemTouchHelper itemTouchHelper;
+
+ private MarginItemDecoration cardMargins = new
MarginItemDecoration(getContext(),
+ R.dimen.view_list_card_margin_horizontal,
R.dimen.view_list_card_margin_vertical,
+ R.dimen.view_list_card_margin_horizontal,
R.dimen.view_list_card_margin_vertical);
public FeedView(Context context) {
super(context);
@@ -59,9 +67,7 @@
recyclerLayoutManager = new StaggeredGridLayoutManager(getColumns(),
StaggeredGridLayoutManager.VERTICAL);
setLayoutManager(recyclerLayoutManager);
- addItemDecoration(new MarginItemDecoration(getContext(),
- R.dimen.view_list_card_margin_horizontal,
R.dimen.view_list_card_margin_vertical,
- R.dimen.view_list_card_margin_horizontal,
R.dimen.view_list_card_margin_vertical));
+ addItemDecoration(cardMargins);
addItemDecoration(new HeaderMarginItemDecoration(getContext(),
R.dimen.view_feed_padding_top));
setCallback(new RecyclerViewColumnCallback());
@@ -102,6 +108,8 @@
// we would need to also notify the layout manager when the
data set changes
// though.
recyclerLayoutManager.setSpanCount(columns);
+ int padding =
roundedDpToPx(getDimension(R.dimen.view_list_card_margin_horizontal));
+ setPadding(padding, 0, padding, 0);
}
}
}
diff --git a/app/src/main/res/values/dimens.xml
b/app/src/main/res/values/dimens.xml
index 6569542..ee1cb11 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -96,8 +96,8 @@
<!-- The Feed -->
<dimen name="view_feed_padding_top">10dp</dimen>
<dimen name="view_feed_min_column_width">320dp</dimen>
- <dimen name="view_list_card_margin_vertical">5dp</dimen>
- <dimen name="view_list_card_margin_horizontal">7dp</dimen>
+ <dimen name="view_list_card_margin_vertical">4dp</dimen>
+ <dimen name="view_list_card_margin_horizontal">8dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_horizontal">4dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_vertical">0dp</dimen>
<dimen name="view_list_card_item_image">40dp</dimen>
--
To view, visit https://gerrit.wikimedia.org/r/368944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I005289dfd3ae57e06e10deed4ff84a7633795801
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
