Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53790


Change subject: Story 440: Promote pageimages to stable on watchlist
......................................................................

Story 440: Promote pageimages to stable on watchlist

Only show them on a to z view
Remove them from feed view

Change-Id: I6b36617ffe29b5d4dfad1ba10c1b2aa73fe6a258
---
M includes/specials/SpecialMobileWatchlist.php
M less/specials/watchlist.less
M stylesheets/specials/watchlist.css
3 files changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/90/53790/1

diff --git a/includes/specials/SpecialMobileWatchlist.php 
b/includes/specials/SpecialMobileWatchlist.php
index 3907e5c..e31c87b 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -17,7 +17,7 @@
                wfProfileIn( __METHOD__ );
 
                $ctx = MobileContext::singleton();
-               $this->usePageImages = $ctx->isBetaGroupMember() && 
!$ctx->imagesDisabled() && defined( 'PAGE_IMAGES_INSTALLED' );
+               $this->usePageImages = !$ctx->imagesDisabled() && defined( 
'PAGE_IMAGES_INSTALLED' );
                // assumes mobile skin
                $mobileSkin = $ctx->getSkin();
                $mobileSkin->setHtmlHeader( $this->getWatchlistHeader() );
@@ -205,8 +205,6 @@
                        }
                }
 
-               $this->doPageImages( $tables, $fields, $join_conds, 
'recentchanges' );
-
                switch( $this->filter ) {
                case 'all':
                        // no-op
@@ -322,7 +320,13 @@
                if ( $empty ) {
                        $this->showEmptyList( $feed );
                } else {
-                       $output->addHtml( '<ul 
class="mw-mf-watchlist-results">' );
+                       $output->addHtml(
+                               Html::openElement( 'ul',
+                                       array(
+                                               'class' => $feed ? 
'mw-mf-watchlist-results' : 'mw-mf-watchlist-results a-to-z',
+                                       )
+                               )
+                       );
 
                        $lookahead = 1;
                        $fromTitle = false;
@@ -459,7 +463,6 @@
                $output->addHtml(
                        '<li>' .
                        Html::openElement( 'a', array( 'href' => $diffLink, 
'class' => 'title' ) ) .
-                       $this->renderThumb( $row ) .
                        Html::element( 'h2', array(), $titleText ).
                        Html::element( 'div', array( 'class' => $usernameClass 
), $username ).
                        Html::element( 'p', array( 'class' => 'mw-mf-comment' 
), $comment ) .
diff --git a/less/specials/watchlist.less b/less/specials/watchlist.less
index 25b098f..e3c3db9 100644
--- a/less/specials/watchlist.less
+++ b/less/specials/watchlist.less
@@ -115,12 +115,10 @@
        }
 }
 
-.beta, .alpha {
-       ul.mw-mf-watchlist-results {
-               li {
-                       a.title {
-                               padding-left: (@thumbSpace - @ragWidth);
-                       }
+ul.mw-mf-watchlist-results.a-to-z {
+       li {
+               a.title {
+                       padding-left: (@thumbSpace - @ragWidth);
                }
        }
 }
diff --git a/stylesheets/specials/watchlist.css 
b/stylesheets/specials/watchlist.css
index 450fa6c..624bb2e 100644
--- a/stylesheets/specials/watchlist.css
+++ b/stylesheets/specials/watchlist.css
@@ -100,8 +100,7 @@
 ul.mw-mf-watchlist-results li .mw-mf-user {
   margin: .5em 0 0;
 }
-.beta ul.mw-mf-watchlist-results li a.title,
-.alpha ul.mw-mf-watchlist-results li a.title {
+ul.mw-mf-watchlist-results.a-to-z li a.title {
   padding-left: 77px;
 }
 #mw-mf-diffview h2 {

-- 
To view, visit https://gerrit.wikimedia.org/r/53790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b36617ffe29b5d4dfad1ba10c1b2aa73fe6a258
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to