Kipcool has submitted this change and it was merged.
Change subject: definingExpression remove_transaction_id can be not null
......................................................................
definingExpression
remove_transaction_id can be not null
Change-Id: I4def6f94a109e9b5aa3892460aab1e04f8c9bf22
---
M OmegaWiki/WikiDataAPI.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Kipcool: Verified; Looks good to me, approved
diff --git a/OmegaWiki/WikiDataAPI.php b/OmegaWiki/WikiDataAPI.php
index bfd2161..02365e8 100644
--- a/OmegaWiki/WikiDataAPI.php
+++ b/OmegaWiki/WikiDataAPI.php
@@ -2091,14 +2091,15 @@
}
$dbr = wfGetDB( DB_SLAVE );
+ // no exp.remove_transaction_id because definingExpression could have
been deleted
+ // but is still needed to form the DM page title.
$spelling = $dbr->selectField(
array( 'dm' => "{$dc}_defined_meaning", 'exp' =>
"{$dc}_expression" ),
'spelling',
array(
'dm.defined_meaning_id' => $definedMeaningId,
'exp.expression_id = dm.expression_id',
- 'dm.remove_transaction_id' => null,
- 'exp.remove_transaction_id' => null
+ 'dm.remove_transaction_id' => null
), __METHOD__
);
--
To view, visit https://gerrit.wikimedia.org/r/53805
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4def6f94a109e9b5aa3892460aab1e04f8c9bf22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Kipcool <[email protected]>
Gerrit-Reviewer: Kipcool <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
