Ori.livneh has submitted this change and it was merged.
Change subject: Append notices to container and float left.
......................................................................
Append notices to container and float left.
Change-Id: I9ac03250581363c1e5dd5622faf147c64a4ef4f5
---
M resources/ext.gettingstarted.accountcreation.js
M resources/ext.gettingstarted.css
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
Spage: Checked; Looks good to me, approved
diff --git a/resources/ext.gettingstarted.accountcreation.js
b/resources/ext.gettingstarted.accountcreation.js
index 1a4a65d..7a1b433 100644
--- a/resources/ext.gettingstarted.accountcreation.js
+++ b/resources/ext.gettingstarted.accountcreation.js
@@ -22,8 +22,8 @@
// Mainly intended for email confirmation message, but others
are possible.
// There is not a more specific selector in core for this.
- $notices = $( '#mw-content-text > p' );
- $notices.insertAfter( $onboardingContainer );
+ $notices = $( '#mw-content-text > p' ).addClass(
'onboarding-notice' );
+ $onboardingContainer.append( $notices );
if ( history.replaceState ) {
state = {}; // Currently unused
diff --git a/resources/ext.gettingstarted.css b/resources/ext.gettingstarted.css
index d5edf4b..8e9419c 100644
--- a/resources/ext.gettingstarted.css
+++ b/resources/ext.gettingstarted.css
@@ -98,8 +98,13 @@
}
/********************* Notifications *********************/
-/* Core currently doesn't offer any more stable selector. */
-#mw-content-text > p {
+/*
+ Core currently doesn't offer a stable selector.
+ We add this class ourselves.
+*/
+.onboarding-notice {
font-size: 0.8em;
color: gray;
+ float: left;
+ margin-left: 6px;
}
--
To view, visit https://gerrit.wikimedia.org/r/53862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ac03250581363c1e5dd5622faf147c64a4ef4f5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
